Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAGING - 22.0.0.2 GA Blog #2032

Merged
merged 16 commits into from Feb 16, 2022
Merged

STAGING - 22.0.0.2 GA Blog #2032

merged 16 commits into from Feb 16, 2022

Conversation

ryan-storey
Copy link
Member

@ryan-storey ryan-storey commented Feb 14, 2022

@ryan-storey
Copy link
Member Author

Added all devs to review their respective blog issue/bug fix sections.

posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
ryan-storey and others added 8 commits February 15, 2022 16:19
Co-authored-by: mbroz2 <mbroz@us.ibm.com>
Co-authored-by: mbroz2 <mbroz@us.ibm.com>
Co-authored-by: mbroz2 <mbroz@us.ibm.com>
Co-authored-by: mbroz2 <mbroz@us.ibm.com>
Co-authored-by: mbroz2 <mbroz@us.ibm.com>
Co-authored-by: mbroz2 <mbroz@us.ibm.com>
Co-authored-by: Adam Yoho <ayoho@us.ibm.com>
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions- in general, it's better to address the reader directly as "you" rather than referring to a 3rd person "user" (unless you expect the reader and the user to be different people)

:url-about: /
//Blank line here is necessary before starting the body of the post.

Open Liberty 22.0.0.2 adds the ability to declare "default" JPA persistence properties to all container-managed persistence contexts as part of the Liberty configuration. This release also provides a number of significant bug fixes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit but I don't think you need quotes around "default", here or elsewhere


* <<jpa, Define JPA persistence properties at server scope>>

View the list of fixed bugs in link:https://github.com/OpenLiberty/open-liberty/issues?q=label%3Arelease%3A22002+label%3A%22release+bug%22[22.0.0.2].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be an anchor-link to the #bugs section of this post? The GitHub list is already linked from line 132

}
----

Or if you're using Docker:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob not an issue for today but should the GA blog template include podman alternative to docker?

[#jpa]
=== Define JPA persistence properties at server scope

This new JPA enhancement adds the ability to declare "default" JPA persistence properties, to all container-managed persistence contexts, as a Liberty `server.xml` configuration.
Copy link
Member

@dmuelle dmuelle Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need commas around the dependent clause here

This new JPA enhancement adds the ability to declare default JPA persistence properties to all container-managed persistence contexts as a Liberty server.xml configuration.


This new JPA enhancement adds the ability to declare "default" JPA persistence properties, to all container-managed persistence contexts, as a Liberty `server.xml` configuration.

Previously, if a persistence property needed to be set for all `persistence.xml` configuration files, a user would manually need to update all `persistence.xml` files in all applications. This could end up requiring hundreds of manual updates and/or rebuilding of applications.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edit

Previously, to set persistence property for all persistence.xml configuration files, you had to update each persistence.xml file in all applications.

This new JPA enhancement adds the ability to declare "default" JPA persistence properties, to all container-managed persistence contexts, as a Liberty `server.xml` configuration.

Previously, if a persistence property needed to be set for all `persistence.xml` configuration files, a user would manually need to update all `persistence.xml` files in all applications. This could end up requiring hundreds of manual updates and/or rebuilding of applications.
With this enhancement, users can specify persistence properties, in the `server.xml`, that will propagate to all container-managed persistence units for applications installed on that server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this enhancement, you can specify persistence properties in the server.xml file that will propagate to all container-managed persistence units for all applications installed on that server.

Previously, if a persistence property needed to be set for all `persistence.xml` configuration files, a user would manually need to update all `persistence.xml` files in all applications. This could end up requiring hundreds of manual updates and/or rebuilding of applications.
With this enhancement, users can specify persistence properties, in the `server.xml`, that will propagate to all container-managed persistence units for applications installed on that server.

In order to start using the new feature, users need only add the new `<defaultProperties>` configuration to their `<jpa>` configuration, in `server.xml`, along with the persistence properties that they want to apply to all container-managed persistence units:
Copy link
Member

@dmuelle dmuelle Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edit

To start using the new feature, add the new defaultProperties element to the jpa element configuration in your server.xml file. Use this element to specify the persistence properties that you want to apply to all container-managed persistence units:


*Technical description*

These `defaultProperties`, integration-level persistence properties will be supplied to the persistence provider specified when the `PersistenceProvider.createContainerEntityManagerFactory` method is called by the JPA Container.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need a comma

These defaultProperties integration-level persistence properties will be supplied to the persistence provider specified when the PersistenceProvider.createContainerEntityManagerFactory method is called by the JPA Container.

posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
epj
epj previously approved these changes Feb 15, 2022
Copy link

@epj epj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSP item looks good


* link:https://github.com/OpenLiberty/open-liberty/issues/19860[Updating MicroProfile versions on server.xml causes issues with install manager]
+
Previously, updating to MicroProfile 5.0 in the `server.xml` and `pom.xml` would cause issues with the install manager. After resolving the features which are needed, the `RepositoryResolver` has to create lists of which features to install. There's a list of everything needed for each requested feature and one for each auto-feature. When creating the install lists, it traversed the dependencies but stopped traversing when it founds a dependency which was installed. If `distributedMap-1.0` is installed but `distributedMapInternal-1.0` is not, it stops traversing dependencies when it hits `distributedMap-1.0` and `distributedMapInternal-1.0` is not added to the list. This bug was fixed by tracing down the entire dependency tree, building the list and finally removing any features which are already installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really describe what the issue was. I'll rewrite it tomorrow morning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, some scenarios will still be impacted by OpenLiberty/open-liberty#19991 which will be fixed in the next release - should that be mentioned here?

Co-authored-by: Tom Evans <tevans@uk.ibm.com>
mbroz2
mbroz2 previously approved these changes Feb 16, 2022
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
Comment on lines +162 to +164
* link:https://github.com/OpenLiberty/open-liberty/issues/19860[Updating MicroProfile versions on server.xml causes issues with install manager]
+
Previously, updating to MicroProfile 5.0 in the `server.xml` and `pom.xml` would cause issues with the install manager. After resolving the features which are needed, the `RepositoryResolver` has to create lists of which features to install. There's a list of everything needed for each requested feature and one for each auto-feature. When creating the install lists, it traversed the dependencies but stopped traversing when it founds a dependency which was installed. If `distributedMap-1.0` is installed but `distributedMapInternal-1.0` is not, it stops traversing dependencies when it hits `distributedMap-1.0` and `distributedMapInternal-1.0` is not added to the list. This bug was fixed by tracing down the entire dependency tree, building the list and finally removing any features which are already installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* link:https://github.com/OpenLiberty/open-liberty/issues/19860[Updating MicroProfile versions on server.xml causes issues with install manager]
+
Previously, updating to MicroProfile 5.0 in the `server.xml` and `pom.xml` would cause issues with the install manager. After resolving the features which are needed, the `RepositoryResolver` has to create lists of which features to install. There's a list of everything needed for each requested feature and one for each auto-feature. When creating the install lists, it traversed the dependencies but stopped traversing when it founds a dependency which was installed. If `distributedMap-1.0` is installed but `distributedMapInternal-1.0` is not, it stops traversing dependencies when it hits `distributedMap-1.0` and `distributedMapInternal-1.0` is not added to the list. This bug was fixed by tracing down the entire dependency tree, building the list and finally removing any features which are already installed.

posts/2022-02-15-ga-release-post.adoc Outdated Show resolved Hide resolved
@mbroz2 mbroz2 merged commit 408a1c7 into staging Feb 16, 2022
@Azquelt
Copy link
Member

Azquelt commented Feb 16, 2022

Here's an updated description for OpenLiberty/open-liberty#19860. I'm not sure whether you want to include this or not, since the fix for OpenLiberty/open-liberty#19991 (which has similar symptoms) won't be included until next release.

In situations where some features are already installed, running featureUtility installServerFeatures would not install all the features required to start the server. Trying to start the server would result in an error like this:

[INFO] [ERROR ] CWWKF0044E: The cdi-3.0 and io.openliberty.distributedMapInternal-1.0 features cannot be loaded at the same time. The cdi-3.0 feature of Jakarta EE 9 is incompatible with the io.openliberty.distributedMapInternal-1.0 feature of Java EE 6. The microProfile-5.0 and microProfile-5.0 configured features include an incompatible combination of features. Your configuration is not supported. Update the configuration to use features that support either the Jakarta EE or Java EE programming models, but not both.

One example where the problem would occur is if the openliberty-jakartaee8 package was extracted, a server was created which required jakartaee-9.1 and featureUtility installServerFeatures was run against that server.

The problem was fixed by updating the install resolver to ensure that the right versions of tolerated dependencies are added to the list of features to install, even if the feature that declares the dependency is already installed.

Note that there is another issue link:https://github.com/OpenLiberty/open-liberty/issues/19991[featureUtility does not pass all features from server.xml to repository resolver] which is still present in this release which can cause similar symptoms if some of the features listed in the server.xml are already installed but others are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants