Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev mode multi module - automate workaround to install ear project to .m2 #1176

Closed
ericglau opened this issue Jun 28, 2021 · 1 comment · Fixed by #1183
Closed

Dev mode multi module - automate workaround to install ear project to .m2 #1176

ericglau opened this issue Jun 28, 2021 · 1 comment · Fixed by #1183
Assignees
@ericglau
Labels
devMode enhancement

Comments

@ericglau
Copy link
Contributor

If the module containing Liberty configuration (specifically, the module without downstream dependencies) has packaging type liberty-assembly or pom and depends on a module of type ear, the user currently needs to install the ear project to the .m2 directory once before running dev mode:  mvn install -pl <ear-module> -am

Dev mode should try to automate this workaround to install the ear project (unless the ear artifact already exists in .m2) before starting dev mode on the liberty-assembly or pom module.
ericglau added a commit to ericglau/ci.maven that referenced this issue Jun 29, 2021
@ericglau
Workaround for OpenLiberty#1176
4dfa72b
ericglau added a commit that referenced this issue Jun 30, 2021
@ericglau
Add integration tests for dev mode with multi module (#1179)
36c0f4e 
* Add multi module test projects

* Substitute LMP version in testcases

* Add multi module IT

* Add testcases

* Add more testcases

* Fix test variables

* Fix copyrights

* Check for app name

* Do not expect unit tests to run on ear projects

* Add test for multi module run

* Print log on assert failure

* Workaround for #1176

* Fix plugin version
@ericglau ericglau self-assigned this Jun 30, 2021
@ericglau ericglau mentioned this issue Jul 6, 2021
Merged
This was referenced Jul 15, 2021
Closed
Closed
jjiwooLim pushed a commit to jjiwooLim/ci.maven that referenced this issue Sep 2, 2021
@ericglau
Add integration tests for dev mode with multi module (OpenLiberty#1179)
3dabdcd 
* Add multi module test projects

* Substitute LMP version in testcases

* Add multi module IT

* Add testcases

* Add more testcases

* Fix test variables

* Fix copyrights

* Check for app name

* Do not expect unit tests to run on ear projects

* Add test for multi module run

* Print log on assert failure

* Workaround for OpenLiberty#1176

* Fix plugin version
@scottkurz scottkurz mentioned this issue Aug 10, 2022
Merged
@scottkurz
Copy link
Member

The #1570 fix addresses this problem without adding/purging from the local .m2 repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericglau ericglau

Labels
devMode enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automate workaround to install ear to .m2 ericglau/ci.maven
2 participants
@scottkurz @ericglau