Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update several plugin versions #1695

Merged
merged 5 commits into from Jun 20, 2023

Conversation

cherylking
Copy link
Member

Related to #1691

Not a fix, but updating some of the versions of maven plugins we are using that are flagged as warnings with -Dmaven.plugin.validation=VERBOSE parameter set.

@cherylking cherylking requested a review from mattbsox June 19, 2023 22:15
@cherylking
Copy link
Member Author

cherylking commented Jun 19, 2023

@mattbsox You will see most of the changes are just a version update, but please pay attention to the two test cases I had to modify. The loose app xml file added file entries for the manifest file instead of dir entries for the META-INF folder. It seems like the skinnyWars setting used to cause the dir entry to happen, but with the update in the maven-ear-plugin version the manifest file is no longer getting created in the temp dir? So we create one in the tmp dir instead and reference it as a file. I don't know if this is an issue/problem.

This is the code in LooseEarApplication I am talking about:

Screenshot 2023-06-19 at 8 48 33 PM

It's going in the last else now, but used to go in the first and second if.

@mattbsox
Copy link
Member

Sorry, missed the comment you made. I think the LGP implementation is always pointing to an existing manifest file, or the file is created in the temp dir if it is null/doesn't exist when passed to the loose app method. I think the change should be okay here too.

@cherylking cherylking merged commit e6a7889 into OpenLiberty:main Jun 20, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants