New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adjusting Spring Boot-related wording of WAR deployment using Spring Boot feature vs. more-standard WAR deployment #7296
Comments
Consolidating here from #7284 support for 3.2 thinning in 24.0.0.1: OpenLiberty/open-liberty#27276 |
Hi @scottkurz - now that the standard WAR process to deploy an SB app is documented in your blog post, I've added clarification and a link to the main SB doc: Before we go into the CLI steps, we provide a link to the SB guide for those who want to use Maven. I added an additional statement that you can deploy an SB app like any other WAR and pointed to the post for more info. We don't often link to blog posts from the docs, but in this case I think it makes sense, particularly since the lack of dev mode support for Spring Boot is just a point-in-time statement that will eventually be resolved. We can review this doc when/if that happens and edit as needed. lmk what you think, thanks |
I took a look. I like the basic idea as an interim step until we do something better. I think, though, it might be a better organizational fit to include the new paragraph somewhere in the initial section, that is BEFORE we get to the individual sections like the All of the information in the subsections after So IMO the best flow is to mention the alternative of a regular deployment earlier. If that seems too long dragging out the intro maybe something shorter like:
|
I like that. It looks good. Two minor comments:
So how about either: "As an alternative to using the optimized Spring Boot deployment described in the following sections, you can also deploy a Spring Boot WAR application like any standard Jakarta EE WAR. " or: "For a WAR application, as an alternative to using the optimized Spring Boot deployment described in the following sections, you can also deploy a Spring Boot application like any standard Jakarta EE WAR. " |
As the draft blog post OpenLiberty/blogs#3655 explains, a Spring Boot WAR can be deployed like any Java EE / Jakarta WAR.
The feature enables the "thinning", bootstrapping via a main() rather than using the servlet initializer, the use of app args, maybe some extra config?, and also the ability to use a JAR package.
However doing a more typical WAR deployment has some advantages too...e.g. you can use dev mode, you can use the default liberty-maven-plugin deployment (so you can deploy like your other WARs).
We don't really discuss this in the doc.
Ideally the lack of dev mode support for Spring Boot is just a point-in-time statement that will eventually be resolved, but there's not a current near-term plan for that.
CC @cbridgha @hlhoots
The text was updated successfully, but these errors were encountered: