Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address final review #14

Merged
merged 13 commits into from Mar 13, 2023
Merged

Address final review #14

merged 13 commits into from Mar 13, 2023

Conversation

shin19991207
Copy link
Contributor

Address final review comments and #13

@shin19991207 shin19991207 linked an issue Mar 9, 2023 that may be closed by this pull request
Restruct the testing application sections #13
Closed
dmuelle
dmuelle requested changes Mar 10, 2023
View reviewed changes
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions for clarity. Let me know if you have any questions- thanks!

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
shin19991207 and others added 11 commits March 10, 2023 13:51
@shin19991207 @dmuelle
Update README.adoc
4417348 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207 @dmuelle
Update README.adoc
74fd4f3 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207 @dmuelle
Update README.adoc
363ed62 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207 @dmuelle
Update README.adoc
cca34b7 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207 @dmuelle
Update README.adoc
370c69d 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207 @dmuelle
Update README.adoc
ba4263e 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207 @dmuelle
Update README.adoc
69d444f 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207 @dmuelle
Update README.adoc
c9c197b 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207 @dmuelle
Update README.adoc
fbe6651 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207 @dmuelle
Update README.adoc
04f082a 
Co-authored-by: David Mueller <48686014+dmuelle@users.noreply.github.com>
@shin19991207
Update README.adoc
1fb7c49 
update to distinguish between mp.config.profile and <config_profile_id>
dmuelle
dmuelle approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@gkwan-ibm gkwan-ibm merged commit f93497c into draft Mar 13, 2023
2 checks passed
@gkwan-ibm gkwan-ibm deleted the final-review branch October 17, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmuelle dmuelle dmuelle approved these changes

@gkwan-ibm gkwan-ibm Awaiting requested review from gkwan-ibm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restruct the testing application sections
3 participants
@shin19991207 @dmuelle @gkwan-ibm