Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed python to java #25

Merged
merged 3 commits into from Nov 8, 2019
Merged

Changed python to java #25

merged 3 commits into from Nov 8, 2019

Conversation

Kubik42
Copy link
Contributor

@Kubik42 Kubik42 commented Aug 29, 2018

No description provided.

Copy link
Member

@lauracowen lauracowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-word to avoid using version numbers at all? Java 6 is out of service so we shouldn't use that in the example but having version numbers will lead this to keep happening.

@gkwan-ibm gkwan-ibm changed the base branch from master to qa October 30, 2019 14:02
@gkwan-ibm
Copy link
Member

@lauracowen I do not have a better long term solution. I just updated not using Java 6. I think it is better to use Java instead of Python. Are you OK for this PR change?

Copy link
Member

@lauracowen lauracowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@gkwan-ibm gkwan-ibm merged commit 6f31f1b into qa Nov 8, 2019
@gkwan-ibm gkwan-ibm deleted the docker-java branch November 8, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants