Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to MP61 and JEE10 #156

Merged
merged 69 commits into from
Apr 3, 2024
Merged

Update to MP61 and JEE10 #156

merged 69 commits into from
Apr 3, 2024

Conversation

shin19991207
Copy link
Contributor

@shin19991207 shin19991207 commented Sep 13, 2023 •
edited by gkwan-ibm
Loading

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Sep 14, 2023 •
edited by Ruilin-Ma
Loading

hi @shin19991207

In general, this PR looks fine. Would you address the following minors:

  • Copyright (c) 2020 ... to Copyright (c) 2020, 2023 ...
  • explain enable.auto.commit=true in the Configuring the MicroProfile Reactive Messaging connectors for Kafka section in the README
  • update startContainers.bat and stopContainers.bat
  • update the Configuring the server section
    • title -> Configuring Liberty
    • ... Open Liberty server ... -> ... Open Liberty ...
  • does all changes in start directory too?
  • can Java 11 run this update? Or 17?
    • Tested on Java 17

@gkwan-ibm gkwan-ibm mentioned this pull request Jan 23, 2024
Closed
Ruilin-Ma
Ruilin-Ma approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@Ruilin-Ma Ruilin-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the guide end to end on SN and Win VM with no issues found.

@gkwan-ibm gkwan-ibm changed the title Update to MP6 and JEE10 Update to MP61 and JEE10 Mar 22, 2024
@gkwan-ibm gkwan-ibm merged commit 760fcd1 into staging Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkwan-ibm gkwan-ibm gkwan-ibm approved these changes

@Ruilin-Ma Ruilin-Ma Ruilin-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shin19991207 @gkwan-ibm @Ruilin-Ma