Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-login-configuration not honored in java:comp/env bindings without binding-name #11044

Closed
njr-11 opened this issue Feb 25, 2020 · 0 comments · Fixed by #11167
Closed

custom-login-configuration not honored in java:comp/env bindings without binding-name #11044

njr-11 opened this issue Feb 25, 2020 · 0 comments · Fixed by #11167
Assignees
Labels
in:Java EE Platform release bug This bug is present in a released version of Open Liberty release:20004 team:Blizzard

Comments

@njr-11
Copy link
Contributor

njr-11 commented Feb 25, 2020

Bindings with a java:comp/env explicitly specified in the name, and without a binding-name specified in the bindings file (it's sent in @Resource instead), do not other parts of the bindings honored.

To work around this, a test case had to use jdbc/dsref as the binding name instead of java:comp/env/jdbc/dsref,
832eff3

An easy way to test this once is is working again would be to switch the bindings in the above test from jdbc/dsref back to java:comp/env/jdbc/dsref,

@njr-11 njr-11 added in:Java EE Platform team:Blizzard release bug This bug is present in a released version of Open Liberty labels Feb 25, 2020
@tkburroughs tkburroughs self-assigned this Feb 25, 2020
tkburroughs added a commit to tkburroughs/open-liberty that referenced this issue Mar 3, 2020
When a jndi-binding-name is present, the resource processor loops through
looking for bindings using both the normalized (short) and denormalized (full)
names (i.e. jdbc/myds & java:comp/env/jdbc/myds). Once found, the additional
res-ref config is located matching that name.

However, when no binding, res-ref config is only located using the normalized (short)
form of the resource ref jndi name.

Fix is added to also look using the denormalized (full) name for two scenarios:
1 - a lookup name was specifiec either on the annotation or xml
2 - no lookup; so using auto-link where DS name is exact match of res-ref short name

Code is added after looking for bindings, to ensure we don't combine bindings
found in the *-bnd.xml file using both short and long forms. Should use only
short form if located, then only long form.
tkburroughs added a commit that referenced this issue Mar 6, 2020
…nored

Issue #11044: Fix res-ref config not honored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:Java EE Platform release bug This bug is present in a released version of Open Liberty release:20004 team:Blizzard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants