Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async implementation of MP rest client returns CompletionStage of Collection of HashMap but expected CompletionStage of Collection of a user defined type #11534

Closed
manish2aug opened this issue Mar 30, 2020 · 1 comment · Fixed by #11544
Closed

Async implementation of MP rest client returns CompletionStage of Collection of HashMap but expected CompletionStage of Collection of a user defined type #11534

manish2aug opened this issue Mar 30, 2020 · 1 comment · Fixed by #11544
Assignees
@andymc12
Labels
bug This bug is not present in a released version of Open Liberty in:JAX-RS in:MicroProfile/RestClient in:MicroProfile Needs member attention release bug This bug is present in a released version of Open Liberty release:20004 team:Wendigo West

Comments

@manish2aug
Copy link

Please find the details below

IBM Liberty version: 19.0.0.4
Features: jaxrs-2.1, jsonp-1.1, jsonb-1.0, mpRestClient-1.2
Gist url: https://gist.github.com/manish2aug/2f5d1e317e2b5bffbec67c7ffbf403ba
Issue: At runtime client doesn't return completion stage of collection of user defined type
@manish2aug manish2aug added the bug This bug is not present in a released version of Open Liberty label Mar 30, 2020
@andymc12 andymc12 added the release bug This bug is present in a released version of Open Liberty label Mar 30, 2020
@andymc12 andymc12 self-assigned this Mar 30, 2020
@andymc12
Copy link
Contributor

This is very similar to issue #6521, but specific to CompletionStage return types. The fix for #6521 intentionally did not handle CompletionStages in the JsonBProvider, assuming that the underlying implementation would handle it, but it doesn't.

I have reproduced this issue and should have a fix shortly.

andymc12 added a commit to andymc12/open-liberty that referenced this issue Mar 30, 2020
@andymc12
[OpenLiberty#11534] Ensure type arguments are preserved for Completio…
9c3ba9d 
…nStage types
@andymc12 andymc12 mentioned this issue Mar 30, 2020
Merged
andymc12 added a commit that referenced this issue Mar 31, 2020
@andymc12
Merge pull request #11544 from andymc12/11534-listsInCompletionStages
c84ec3d 
[#11534] Ensure type arguments are preserved for CompletionStage types
@manish2aug manish2aug mentioned this issue Apr 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andymc12 andymc12

Labels
bug This bug is not present in a released version of Open Liberty in:JAX-RS in:MicroProfile/RestClient in:MicroProfile Needs member attention release bug This bug is present in a released version of Open Liberty release:20004 team:Wendigo West
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#11534] Ensure type arguments are preserved for CompletionStage types andymc12/open-liberty
3 participants
@manish2aug @andymc12 @LibbyBot