Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta Transformer Build Integration: Support additional BND directives #12445

Closed
cbridgha opened this issue Jun 1, 2020 · 1 comment · Fixed by #13247
Closed

Jakarta Transformer Build Integration: Support additional BND directives #12445

cbridgha opened this issue Jun 1, 2020 · 1 comment · Fixed by #13247

Comments

@cbridgha
Copy link
Member

cbridgha commented Jun 1, 2020

Per the linked pull request, new BND directives were added as follows:

Override the transformed bundle name:
  'jakartaFinalJarName'

Supply local properties files; these must be placed in a project 'rules' folder:
  'jakartaLocalSelections'
  'jakartaLocalRenames'
  'jakartaLocalVersions'
  'jakartaLocalBundles'
  'jakartaLocalDirect'
  'jakartaLocalTextMaster'

Add specific bundle update data:
  'jakartaInitialBundleId'
  'jakartaFinalBundleId'
  'jakartaFinalBundleVersion'
  'jakartaFinalBundleShortName'
  'jakartaFinalBundleDescription'

See task 'jakartaeeTransform' in 'https://github.com/OpenLiberty/open-liberty/blob/integration/dev/wlp-gradle/subprojects/tasks.gradle' for implementation details.


The existing BND directive to activate the jakarta transformer is a simple true/false flag.

We have had a request to override the default transformed jar name

  • existing is .jakarta.jar

New directives:
jakartaee.transform.jar.name=<new jar name>

MANIFEST - directives...

JakartaEE-Bundle-Name: ...
JakartaEE-Bundle-Symbolic-Name: ...
JakartaEE-Bundle-Version: ...
JakartaEE-Bundle-Description: ...

These properties would then be passed via command line arguments to the transformer.

@tbitonti
Copy link
Contributor

tbitonti commented Jul 7, 2020

The ability to choose an output name that is different than the current jakarta name can be handled entirely through the build scripts: The transformer uses an explicit "output file name" parameter, and the build scripts are free to specify whatever particular output name is appropriate.

The other BND directives will require either more extensive build scripting (to dynamically generate rules files for the transformer), or will require new command line options to the transformer tool. My sense is that adding new options is the better way to provide the new function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants