Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line rules data additions #25

Closed
bjhargrave opened this issue Jun 2, 2020 · 3 comments · Fixed by #89
Closed

Command line rules data additions #25

bjhargrave opened this issue Jun 2, 2020 · 3 comments · Fixed by #89
Assignees
Labels
enhancement New feature or request

Comments

@bjhargrave
Copy link
Member

From @tbitonti

Open-liberty, when specifying bundle identity updates, would prefer to specify the identity information at the project level and through command line arguments, instead of through a global rules file. For example:

JavaEE-Bundle-Symbolic-Name: ...
JakartaEE-Bundle-Symbolic-Name: ...
JakartaEE-Bundle-Name: ...
JakartaEE-Bundle-Version: ...
JakartaEE-Bundle-Description: ...

These would be read and processed by BND tooling in the open-liberty build and would be provided to the transformer using a new command line option.

Possibly:

--rule-data ruleName ruleDataLine

"ruleDataLine" would add to the data from the rules properties file matching the specified "ruleName".

@bjhargrave bjhargrave added the enhancement New feature or request label Jun 2, 2020
@bjhargrave
Copy link
Member Author

From @tbitonti

open-liberty issue: OpenLiberty/open-liberty#12445

jfdenise added a commit to jfdenise/transformer-1 that referenced this issue Jun 3, 2020
jfdenise added a commit to jfdenise/transformer-1 that referenced this issue Jun 4, 2020
Signed-off-by: JF Denise <jdenise@redhat.com>
@tbitonti tbitonti self-assigned this Jul 8, 2020
@tbitonti tbitonti linked a pull request Jul 16, 2020 that will close this issue
@tbitonti
Copy link
Contributor

Test plan for immediate package renames:

The test plan is to update a manifest using package rename data.

The test includes package rename data and linked package version data.

Four package names are present in the test data:

The first package name and version are updated by property file data.
The second package name and version are updated by property file data, but that is overwritten by immediate data.
The third package name and version are updated by immediate data.
The fourth package name and version are not updated.

The initial and final package values in the manifest are:

javax.package0;version="0.0.0"         jakarta.package0;version="0.0.1"
javax.package1;version="1.0.0"         jakarta.package11;version="1.1.1"
javax.package2;version="2.0.0"         jakarta.package22;version="2.1.1"
javax.package3;version="3.0.0"         jakarta.package3;version="3.0.0"

Property file ane immediate data:

tier0: javax.package0=jakarta.package0
         javax.package1=jakarta.package1

immediate: javax.package1=jakarta.package11
                   javax.package2=jakarta.package22

tier0: jakarta.package0="0.0.1"
         jakarta.package1="1.0.1"

immediate: jakarta.package11="1.1.1"
                   jakarta.package22="2.1.1"

Command line options are:

	"-tr", DATA_DIR + '/' + "tier0.renames.properties",
	"-tv", DATA_DIR + '/' + "tier0.versions.properties",

         "-ti", "tr", "javax.package1", "jakarta.package11",
         "-ti", "tr", "javax.package2", "jakarta.package22",

         "-ti", "tv", "jakarta.package11", "1.1.1",
         "-ti", "tv", "jakarta.package22", "2.1.1"

@tbitonti
Copy link
Contributor

One more commit: Refactoring of the new tests to move common methods to TestUtils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants