Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run MicroProfile 6.0 TCKs using only EE10 core profile features #22348

Closed
6 of 8 tasks
Azquelt opened this issue Aug 31, 2022 · 3 comments · Fixed by #23205
Closed
6 of 8 tasks

Run MicroProfile 6.0 TCKs using only EE10 core profile features #22348

Azquelt opened this issue Aug 31, 2022 · 3 comments · Fixed by #23205

Comments

@Azquelt
Copy link
Member

Azquelt commented Aug 31, 2022

Ideally, all the MP 6.0 features should pass their TCK using only EE10 core profile (which doesn't include servlet)

@Azquelt Azquelt created this issue from a note in MicroProfile UK (Planned) Aug 31, 2022
@Azquelt Azquelt changed the title Run MicroProfile 6.0 TCKs using EE10 core profile Run MicroProfile 6.0 TCKs using only EE10 core profile features Aug 31, 2022
@tevans78 tevans78 moved this from Planned to In Progress in MicroProfile UK Sep 15, 2022
@Azquelt
Copy link
Member Author

Azquelt commented Oct 26, 2022

mpTelemetry-1.0 cannot currently run with the arquillian REST protocol because the rest requests create spans which the test is not expecting.

To avoid this, I think we would need either a change to the TCK to ignore spans created by the framework, or a change to the product to exclude certain requests from creating spans. I don't think either option makes sense to prioritise before the release of 1.0 and we should continue running with servlet enabled.

I've opened an issue for the TCK here: eclipse/microprofile-telemetry#72

@Azquelt
Copy link
Member Author

Azquelt commented Oct 27, 2022

We will not do these last two remaining TCKs. I will check that the server.xml is manually pulling in servlet and ensure there is a comment to say why it's there.

@Azquelt
Copy link
Member Author

Azquelt commented Oct 31, 2022

@tevans78 After documenting why the two remaining TCKs still require servlet, I don't think there's anything else to do for this issue.

MicroProfile UK automation moved this from In Progress to Done Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

1 participant