Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCK cannot be run using the Arquillian REST protocol #72

Closed
Azquelt opened this issue Oct 27, 2022 · 2 comments · Fixed by #112
Closed

TCK cannot be run using the Arquillian REST protocol #72

Azquelt opened this issue Oct 27, 2022 · 2 comments · Fixed by #112
Assignees
Milestone

Comments

@Azquelt
Copy link
Member

Azquelt commented Oct 27, 2022

Describe the bug

Arquillian recently introduced the REST 3.0 testing protocol to allow remote and managed testing in environments where the servlet APIs are not present.

It would be nice to be able to use this so that the MP Telemetry TCK can be run in an environment which strictly only provides Jakarta EE core (which does not include servlet).

However, the rest requests made by arquillian have spans created for them which causes some of our tests to fail because there are more spans than expected collected by the InMemorySpanExporter.

We could fix this by either detecting and ignoring spans created by arquillian, or by somehow marking the spans which are part of the test.

@Emily-Jiang
Copy link
Member

@Azquelt does this need to be fixed prior to 1.0 release?

@Azquelt
Copy link
Member Author

Azquelt commented Oct 27, 2022

I don't think so. It would only cause problems for an implementer who could not provide a servlet container, and I don't think there are any of those at the moment.

However, if there someone did want to certify and could not provide a servlet container, I think this would be a valid challenge and it would invalidate most of the tests so we should definitely make sure we do it for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants