Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolationLevel=TRANSACTION_NONE on dataSource config #3917

Closed
njr-11 opened this issue Jun 8, 2018 · 5 comments
Closed

isolationLevel=TRANSACTION_NONE on dataSource config #3917

njr-11 opened this issue Jun 8, 2018 · 5 comments
Assignees
Labels
Epic Used to track Feature Epics that are following the UFO process FAT complete This label is not part of the feature process and will be deleted. Use `target:ga` label instead. focalApproved:accessibility Focal Approval granted for Accessibility for the feature focalApproved:fat Focal Approval granted for FAT for the feature focalApproved:id Focal Approval granted for ID for the feature story target:18003 team:Zombie Apocalypse

Comments

@njr-11
Copy link
Contributor

njr-11 commented Jun 8, 2018

Statement of user story:
"As a user of database connectivity in Liberty, I would like the Liberty dataSource configuration to permit me to configure a default isolation level of TRANSACTION_NONE so that I can use a JDBC driver that does not support transactions while still taking advantage of value added capabilities such as connection pooling and statement caching."

Specifically, this will involve the introduction of an isolationLevel option, TRANSACTION_NONE. It might be necessary to internally use different constant value than the spec one for this because the spec one appears to have been abused for other purposes (means unspecified on resource ref).

When TRANSACTION_NONE is used as the isolation level for a connection, Liberty should not make any attempt to enlist the connection in global transactions, instead considering it similarly to transactional=false path. Should consider rejecting the setAutoCommit(false) operation in case the JDBC driver doesn't.

Tests should ensure that dataSource configured with isolationLevel=TRANSACTION_NONE can be used with or without a resource-ref, that it reports Connection.getTransactionIsolation() as Connection.TRANSACTION_NONE, and that operations made on the connection are not enlisted into a global transaction. For example, if the global transaction surrounding the code block rolls back, updates made using the TRANSACTION_NONE connection are not rolled back.

@gkwan-ibm
Copy link
Member

Serviceability Approval Comment - Please answer the following questions for serviceability approval (note that this is a new approval step -- comments welcome on how to improve it):

  1. WAD -- does the WAD identify the most likely problems customers will see and identify how the feature will enable them to diagnose and solve those problems without resorting to raising a PMR? Have these issues been addressed in the implementation?

  2. Test and Demo -- As part of the new serviceability process we're asking feature teams to test and analyze common problem paths for serviceability and demo those problem paths to someone not involved in the development of the feature (eg. L2, test team, or another development team).
    a) What problem paths were tested and demonstrated?
    b) Who did you demo to?
    c) Do the people you demo'd to agree that the serviceability of the demonstrated problem scenarios is sufficient to avoid PMRs for any problems customers are likely to encounter, or that L2 should be able to quickly address those problems without need to engage L3?

  3. SVT -- SVT team is often the first team to try new features and often encounters problems setting up and using them. Note that we're not expecting SVT to do full serviceability testing -- just to sign-off on the serviceability of the problem paths they encountered.
    a) Who conducted SVT tests for this feature?
    b) Do they agree that the serviceability of the problems they encountered is sufficient to avoid PMRs, or that L2 should be able to quickly address those problems without need to engage L3?

  4. Queues -- Which L2 / L3 queues will handle PMRs for this feature? Do the respective L2 / L3 teams know they are supporting it?

@alexsm82 alexsm82 added the FAT complete This label is not part of the feature process and will be deleted. Use `target:ga` label instead. label Aug 16, 2018
@alexsm82
Copy link
Contributor

Hi @gkwan-ibm. Given this was completed as a story rather than a feature we won't be going through the feature approval process on this item.

@gscottj gscottj added the focalApproved:accessibility Focal Approval granted for Accessibility for the feature label Aug 17, 2018
@marikaj123 marikaj123 removed the FAT complete This label is not part of the feature process and will be deleted. Use `target:ga` label instead. label Aug 20, 2018
@alexsm82 alexsm82 added the FAT complete This label is not part of the feature process and will be deleted. Use `target:ga` label instead. label Aug 20, 2018
@alexsm82
Copy link
Contributor

@marikaj123 adding focalApprovalReady tag on as this story needs FAT approval.

@bsbyrd1 bsbyrd1 added the focalApproved:id Focal Approval granted for ID for the feature label Aug 20, 2018
@bsbyrd1
Copy link
Member

bsbyrd1 commented Aug 20, 2018

No ID is required for this feature.

@dave-waddling
Copy link
Member

FAT Focal Approval: The Feature Test Summary looks good and the code made it into the SOE over the weekend where it passed across the board. Approval granted.

@dave-waddling dave-waddling added the focalApproved:fat Focal Approval granted for FAT for the feature label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Used to track Feature Epics that are following the UFO process FAT complete This label is not part of the feature process and will be deleted. Use `target:ga` label instead. focalApproved:accessibility Focal Approval granted for Accessibility for the feature focalApproved:fat Focal Approval granted for FAT for the feature focalApproved:id Focal Approval granted for ID for the feature story target:18003 team:Zombie Apocalypse
Projects
None yet
Development

No branches or pull requests

9 participants