Small rye open api #13589

If you're going to reformat the whole file, please do it in a separate commit because otherwise your real changes get lost amongst the noise of the formatting changes.

...here.appserver.features/visibility/public/mpOpenAPI-2.0/io.openliberty.mpOpenAPI-2.0.feature

dev/com.ibm.ws.microprofile.openapi_fat/.settings/org.eclipse.jdt.ui.prefs

dev/com.ibm.ws.microprofile.openapi_fat/bnd.bnd

...icroprofile.openapi_fat/fat/src/com/ibm/ws/microprofile/openapi/fat/UICustomizationTest.java

...api_fat/fat/src/com/ibm/ws/microprofile/openapi/validation/fat/OpenAPIValidationTestOne.java

...file.openapi.2.0.internal/src/io/openliberty/microprofile/openapi20/ApplicationListener.java

...ile.openapi.2.0.internal/src/io/openliberty/microprofile/openapi20/ApplicationProcessor.java

...file.openapi.2.0.internal/src/io/openliberty/microprofile/openapi20/ApplicationListener.java

...napi.2.0.internal/src/io/openliberty/microprofile/openapi20/css/OpenAPIUIBundlesUpdater.java

...ile.openapi.2.0.internal/src/io/openliberty/microprofile/openapi20/ApplicationProcessor.java

Azquelt · 2020-09-04T11:19:09Z

...ile.openapi.2.0.internal/src/io/openliberty/microprofile/openapi20/ApplicationProcessor.java

+                OpenApiDocument.INSTANCE.modelFromStaticFile(OpenApiProcessor.modelFromStaticFile(staticFile));
+//                OpenApiDocument.INSTANCE.modelFromAnnotations(OpenApiProcessor.modelFromAnnotations(config, IndexUtils.getIndexView(appClassloader, appContainer, config)));
+                OpenApiDocument.INSTANCE.modelFromAnnotations(OpenApiProcessor.modelFromAnnotations(config, IndexUtils.getIndexView(moduleInfo, config)));


Another commented out line

Azquelt · 2020-09-04T12:27:39Z

...profile.openapi.2.0.internal/src/io/openliberty/microprofile/openapi20/utils/CloudUtils.java

+     *          The host specified in VCAP_APPLICATION or null if it is not set.
+     */
+    @FFDCIgnore(Exception.class)
+    public static String getVCAPHost() {


Do you still want to support this?

Good question. Do Liberty instances still run in Cloud Foundry environments? If so, then I guess we need to continue to support it.

However, it does raise the question of what we need to do to ensure that the correct host/port are included in the servers section when OL is running in OpenShift... sitting behind a service or, indeed, a route.

This is additional behaviour when running in CF. I have no idea whether it's still required. I know we specifically opted not to do anything additional for CF on the reactive messaging feature, for example.

Ok... and we could certainly take that approach for OpenAPI since users are able to specify their own content for the servers section using a variety of mechanisms.

Ok, I don't mind either way, just as long as we've thought about it and decided what to do, rather than accidentally releasing something which we then have to support forever.

Azquelt · 2020-09-04T12:29:19Z

...icroprofile.openapi.2.0.internal/src/io/openliberty/microprofile/openapi20/package-info.java

+@Version(Constants.OSGI_VERSION)
+@TraceOptions(traceGroup = Constants.TRACE_GROUP, messageBundle = Constants.TRACE_OPENAPI)
+package io.openliberty.microprofile.openapi20;


This isn't how you're supposed to version packages.

Should be 1.0 in the release, with the major and minor versions being updated for future releases in accordance with semantic versioning.

So... simply change Constants::OSGI_VERSION to be "1.0"?

For now that will do, going forwards, packages are versioned individually, so they're unlikely to have the same version.

Azquelt · 2020-09-04T13:28:03Z

There's an awful lot of code in this PR for a feature where we're pulling in a third-party library to do most of the work.

msmiths · 2020-09-04T13:33:44Z

@Azquelt The majority of the code is the value add functionality that is not part of the MP OpenAPI specification, i.e.:

Validation
UI customization

If we were not continuing to support the value add functionality, we could get rid of approx. 45 java classes.

However, even in its current form, there are still significantly less classes than in the previous implementation in the com.ibm.ws.microprofile.openapi project because we are relying on SmallRye to do the annotation scanning... which is the bulk of the code.

Azquelt · 2020-09-04T13:34:07Z

Gotcha, that makes sense 👍

Azquelt

This looks good and we've talked through the remaining outstanding points.

msmiths · 2020-09-04T15:15:21Z

#run-libby-bot #build

LibbyBot · 2020-09-04T15:15:29Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2020-09-04T15:15:32Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_F5W4sO65EeqT3K3gf94lOQ

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2020-09-04T22:45:43Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_F5W4sO65EeqT3K3gf94lOQ/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_F5W4sO65EeqT3K3gf94lOQ.

LibbyBot · 2020-09-05T01:45:24Z

The build msmiths-13589-20200904-1545
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_F5W4sO65EeqT3K3gf94lOQ
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_F5W4sO65EeqT3K3gf94lOQ

MP OpenAPI 2.0 Initial Implementation Remove com.ibm.ws.require.java8 bundle from .feature Signed-off-by: Martin Smithson <msmiths@uk.ibm.com> Specify edition-full in private .feature file Signed-off-by: Martin Smithson <msmiths@uk.ibm.com> Use the 2.0-RC2 version of MP OpenAPI Signed-off-by: Martin Smithson <msmiths@uk.ibm.com> Apply PR review comments Signed-off-by: Martin Smithson <msmiths@uk.ibm.com> Apply more PR review comments Signed-off-by: Martin Smithson <msmiths@uk.ibm.com>

msmiths · 2020-09-07T11:32:34Z

#run-libby-bot #build

LibbyBot · 2020-09-07T11:32:39Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2020-09-07T11:32:44Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_dt10oPD1Eeq2j8eW2p4naw

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2020-09-07T11:32:47Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

106 product code files were changed.
Please describe in a separate comment how you tested your changes.
27 infrastructure code files were changed.
45 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
30 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_ro.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_ja.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_ru.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_fr.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_it.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_pl.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_ko.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_cs.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_ja.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_zh.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_pt_BR.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_de.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_pt_BR.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_es.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_zh.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_hu.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_de.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_ru.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_ro.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_es.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_it.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_zh_TW.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_fr.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_ko.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_pl.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_hu.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_zh_TW.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_cs.nlsprops
31 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_ro.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_ja.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_ru.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_fr.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_it.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_pl.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_ko.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_cs.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_ja.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_zh.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_pt_BR.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_de.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_pt_BR.nlsprops
dev/com.ibm.websphere.appserver.features/visibility/public/mpOpenAPI-2.0/resources/l10n/io.openliberty.mpOpenAPI-2.0.properties
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_es.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_zh.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_hu.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_de.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_ru.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_ro.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_es.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_it.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_zh_TW.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_fr.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_ko.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_pl.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_hu.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/validation/resources/ValidationMessages_zh_TW.nlsprops
dev/io.openliberty.microprofile.openapi.2.0.internal/resources/io/openliberty/microprofile/openapi20/resources/OpenAPI_cs.nlsprops

LibbyBot · 2020-09-07T16:16:20Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_dt10oPD1Eeq2j8eW2p4naw/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_dt10oPD1Eeq2j8eW2p4naw.

LibbyBot · 2020-09-07T21:05:35Z

The build msmiths-13589-20200907-1146
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_dt10oPD1Eeq2j8eW2p4naw
completed successfully!

LibbyBot added the CLA Signed label Aug 21, 2020

tevans78 reviewed Aug 24, 2020

View reviewed changes

...here.appserver.features/visibility/public/mpOpenAPI-2.0/io.openliberty.mpOpenAPI-2.0.feature Outdated Show resolved Hide resolved

msmiths force-pushed the smallRyeOpenAPI branch from bea0a66 to 5a828e1 Compare August 24, 2020 13:30

msmiths force-pushed the smallRyeOpenAPI branch from d45b014 to d8ab652 Compare August 25, 2020 12:12

tevans78 reviewed Aug 25, 2020

View reviewed changes

...rver.features/visibility/private/io.openliberty.org.eclipse.microprofile.openapi-2.0.feature Outdated Show resolved Hide resolved

skasund added the L2 Reviewed label Aug 26, 2020

Azquelt reviewed Sep 3, 2020

View reviewed changes

...rofile.openapi_fat/fat/src/com/ibm/ws/microprofile/openapi/fat/ApplicationProcessorTest.java Outdated Show resolved Hide resolved

Azquelt reviewed Sep 3, 2020

View reviewed changes

...om.ibm.ws.microprofile.openapi_fat/fat/src/com/ibm/ws/microprofile/openapi/fat/FATSuite.java Outdated Show resolved Hide resolved

Azquelt reviewed Sep 3, 2020

View reviewed changes

...here.appserver.features/visibility/public/mpOpenAPI-2.0/io.openliberty.mpOpenAPI-2.0.feature Outdated Show resolved Hide resolved

Azquelt requested changes Sep 3, 2020

View reviewed changes

Azquelt reviewed Sep 4, 2020

View reviewed changes

...napi.2.0.internal/src/io/openliberty/microprofile/openapi20/css/OpenAPIUIBundlesUpdater.java Show resolved Hide resolved

Azquelt reviewed Sep 4, 2020

View reviewed changes

...ile.openapi.2.0.internal/src/io/openliberty/microprofile/openapi20/ApplicationProcessor.java Show resolved Hide resolved

Azquelt reviewed Sep 4, 2020

View reviewed changes

Azquelt approved these changes Sep 4, 2020

View reviewed changes

msmiths force-pushed the smallRyeOpenAPI branch from d45f61d to 77bbb02 Compare September 7, 2020 10:29

msmiths merged commit 7b67654 into OpenLiberty:integration Sep 8, 2020

msmiths mentioned this pull request Sep 23, 2020

Schema property "implementation" prints the whole object instead of $ref in "/openapi" #14075

Closed

scottcurtis2605 mentioned this pull request Dec 9, 2020

Feature Test Summary for OpenAPI 2.0 #14186

Closed

Small rye open api #13589

Small rye open api #13589

Conversation

msmiths commented Aug 21, 2020

msmiths commented Aug 21, 2020

LibbyBot commented Aug 21, 2020

LibbyBot commented Aug 21, 2020

LibbyBot commented Aug 21, 2020

LibbyBot commented Aug 21, 2020

msmiths commented Aug 24, 2020

msmiths commented Aug 24, 2020

LibbyBot commented Aug 24, 2020

LibbyBot commented Aug 24, 2020

LibbyBot commented Aug 24, 2020

LibbyBot commented Aug 24, 2020

msmiths commented Aug 25, 2020

LibbyBot commented Aug 25, 2020

LibbyBot commented Aug 25, 2020

LibbyBot commented Aug 25, 2020

LibbyBot commented Aug 26, 2020

msmiths commented Aug 26, 2020

LibbyBot commented Aug 26, 2020

LibbyBot commented Aug 26, 2020

skasund commented Aug 26, 2020

LibbyBot commented Aug 26, 2020

LibbyBot commented Aug 26, 2020

Azquelt commented Sep 3, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Azquelt commented Sep 4, 2020

msmiths commented Sep 4, 2020 • edited

Azquelt commented Sep 4, 2020

Azquelt left a comment

Choose a reason for hiding this comment

msmiths commented Sep 4, 2020

LibbyBot commented Sep 4, 2020

LibbyBot commented Sep 4, 2020

LibbyBot commented Sep 4, 2020

LibbyBot commented Sep 5, 2020

msmiths commented Sep 7, 2020

LibbyBot commented Sep 7, 2020

LibbyBot commented Sep 7, 2020

LibbyBot commented Sep 7, 2020

Code analysis and actions

LibbyBot commented Sep 7, 2020

LibbyBot commented Sep 7, 2020

msmiths commented Sep 4, 2020 •

edited