Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection manager deadlock when purgePolicy=FailingConnectionOnly #14668

Conversation

gjwatts
Copy link
Member

@gjwatts gjwatts commented Oct 23, 2020

Modify the com.ibm.ejs.j2c.PoolManager.validateConnections method to prevent a potential deadlock from occurring on a connection that may be used on another thread when purgePolicy=FailingConnectionOnly.

Fixes #14657

@gjwatts gjwatts self-assigned this Oct 23, 2020
@gjwatts gjwatts force-pushed the 14657-fix-connection-manager-deadlock-validateConnections branch from 9d68441 to d68408a Compare October 23, 2020 02:05
@gjwatts
Copy link
Member Author

gjwatts commented Oct 23, 2020

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lTc4ABTMEeuFUN9G2T7ZeA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build gjwatts-14668-20201023-0217
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lTc4ABTMEeuFUN9G2T7ZeA
completed successfully!

@jmstephensgit jmstephensgit self-requested a review October 23, 2020 15:35
@gjwatts gjwatts force-pushed the 14657-fix-connection-manager-deadlock-validateConnections branch 2 times, most recently from daa8412 to 21a78d2 Compare October 23, 2020 19:04
@gjwatts gjwatts force-pushed the 14657-fix-connection-manager-deadlock-validateConnections branch from 21a78d2 to 6c24c8c Compare October 23, 2020 19:08
@gjwatts
Copy link
Member Author

gjwatts commented Oct 23, 2020

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5pZs8BVaEeuFUN9G2T7ZeA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

@LibbyBot
Copy link

The build gjwatts-14668-20201023-1915
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5pZs8BVaEeuFUN9G2T7ZeA
completed successfully!

@gjwatts
Copy link
Member Author

gjwatts commented Oct 26, 2020

#libbybot

* Get all of the managed connections wrappers.
*/
// boolean b = false;
// if (b) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the commented out code here and the old commented out code.

@gjwatts
Copy link
Member Author

gjwatts commented Nov 3, 2020

#libbybot

@gjwatts
Copy link
Member Author

gjwatts commented Nov 3, 2020

#build

@LibbyBot
Copy link

LibbyBot commented Nov 3, 2020

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

LibbyBot commented Nov 3, 2020

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_8hvjAB4hEeuPC7nYV-RLig

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Nov 4, 2020

@LibbyBot
Copy link

LibbyBot commented Nov 4, 2020

The build gjwatts-14668-20201103-2322
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_8hvjAB4hEeuPC7nYV-RLig
completed successfully!

@gjwatts
Copy link
Member Author

gjwatts commented Nov 4, 2020

I had made a couple of changes that Kyle recommended and then rebuilt. The testing passed, so merging changes.

@gjwatts gjwatts merged commit 5763426 into OpenLiberty:integration Nov 4, 2020
@gjwatts gjwatts deleted the 14657-fix-connection-manager-deadlock-validateConnections branch November 4, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix connection manager deadlock for purgePolicy=FailingConnectionOnly
3 participants