-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connection manager deadlock when purgePolicy=FailingConnectionOnly #14668
Fix connection manager deadlock when purgePolicy=FailingConnectionOnly #14668
Conversation
9d68441
to
d68408a
Compare
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lTc4ABTMEeuFUN9G2T7ZeA Target locations of links might be accessible only to IBM employees. |
Your Open Liberty build results are ready for viewing.
|
The build gjwatts-14668-20201023-0217 |
daa8412
to
21a78d2
Compare
21a78d2
to
6c24c8c
Compare
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5pZs8BVaEeuFUN9G2T7ZeA Target locations of links might be accessible only to IBM employees. |
Your Open Liberty build results are ready for viewing.
|
The build gjwatts-14668-20201023-1915 |
#libbybot |
* Get all of the managed connections wrappers. | ||
*/ | ||
// boolean b = false; | ||
// if (b) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the commented out code here and the old commented out code.
#libbybot |
#build |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_8hvjAB4hEeuPC7nYV-RLig Target locations of links might be accessible only to IBM employees. |
Your Open Liberty build results are ready for viewing.
|
The build gjwatts-14668-20201103-2322 |
I had made a couple of changes that Kyle recommended and then rebuilt. The testing passed, so merging changes. |
Modify the com.ibm.ejs.j2c.PoolManager.validateConnections method to prevent a potential deadlock from occurring on a connection that may be used on another thread when purgePolicy=FailingConnectionOnly.
Fixes #14657