Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override doTrace to avoid automatic TRACE request rejection #15265

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

andymc12
Copy link
Contributor

The web container rejects TRACE requests by default - with or without the security features enabled. When security is disabled, this can be worked around by setting <webContainer enableTraceRequests="true"/> in the server.xml, but that will not work when security is enabled. To ensure that TRACE requests are not rejected when security is enabled, we must override the doTrace method in IBMRestServlet.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@andymc12
Copy link
Contributor Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_4UDikDsVEeufrbKPAMj-zQ

Target locations of links might be accessible only to IBM employees.

@andymc12
Copy link
Contributor Author

also see related issue #15263

Copy link
Member

@jim-krueger jim-krueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LibbyBot
Copy link

@LibbyBot
Copy link

The build andymc12-15265-20201210-1938
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_4UDikDsVEeufrbKPAMj-zQ
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_4UDikDsVEeufrbKPAMj-zQ

@andymc12
Copy link
Contributor Author

Single failures occurs in other builds and is not related to these changes.

@andymc12 andymc12 merged commit d234f47 into OpenLiberty:integration Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants