Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply MYFACES-4658 and MYFACES-4605 #28172

Merged
merged 3 commits into from
May 9, 2024
Merged

Apply MYFACES-4658 and MYFACES-4605 #28172

merged 3 commits into from
May 9, 2024

Conversation

volosied
Copy link
Member

fixes #28118

@volosied volosied self-assigned this Apr 16, 2024
@LibbyBot
Copy link

The following files contain a string indicating discriminating content:

  • dev/io.openliberty.jakarta.faces.4.0/src/META-INF/resources/jakarta.faces/faces-development.js

@volosied volosied changed the title Apply MYFACES-4658 Apply MYFACES-4658 and MYFACES-4605 Apr 16, 2024
@volosied
Copy link
Member Author

#libby

@LibbyBot
Copy link

The following files contain a string indicating discriminating content:

  • dev/io.openliberty.jakarta.faces.4.0/src/META-INF/resources/jakarta.faces/faces-development.js

@volosied volosied force-pushed the 281180-faces-4.0 branch 3 times, most recently from e0bbd58 to 958867f Compare April 26, 2024 19:13
@volosied
Copy link
Member Author

#build #spawn.fullfat.buckets=io.openliberty.org.apache.myfaces.4.0_fat

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_wr4DIAP4Ee-LkpmtVFSl9A

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=6df24f09-6cb0-4812-9bd6-e19e6c8d1f7e

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build volosied-28172-20240426-1223
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_wr4DIAP4Ee-LkpmtVFSl9A
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_wr4DIAP4Ee-LkpmtVFSl9A

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=6df24f09-6cb0-4812-9bd6-e19e6c8d1f7e has errors/failures.

@volosied volosied force-pushed the 281180-faces-4.0 branch 2 times, most recently from acc434b to 2c2a5d5 Compare April 29, 2024 18:26
@volosied
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ye6s4AZPEe-9IeXbkm35aA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=b9004339-a2fd-4c7c-ba2e-4639a8fadb44

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=b9004339-a2fd-4c7c-ba2e-4639a8fadb44 has errors/failures.

@LibbyBot
Copy link

The build volosied-28172-20240429-1151
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ye6s4AZPEe-9IeXbkm35aA
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_ye6s4AZPEe-9IeXbkm35aA

@LibbyBot
Copy link

LibbyBot commented May 1, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_GxR44Ae7Ee-9IeXbkm35aA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented May 1, 2024

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8c421dfc-54e2-4583-ad82-b80a3af51b03

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented May 1, 2024

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8c421dfc-54e2-4583-ad82-b80a3af51b03 has errors/failures.

@LibbyBot
Copy link

LibbyBot commented May 2, 2024

The build volosied-28172-20240501-0745
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_GxR44Ae7Ee-9IeXbkm35aA
completed successfully!

pnicolucci
pnicolucci previously approved these changes May 7, 2024
View reviewed changes
@volosied
Apply MYFACES-4658
b7f72db 
change terms
@volosied
Copy link
Member Author

volosied commented May 7, 2024

#build

@LibbyBot
Copy link

LibbyBot commented May 7, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_yZdLgAyZEe-d7o-0EQ2ULA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented May 7, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=ff0eaf0b-78b8-429f-b00c-0e261b4b9c1c

Target locations of links might be accessible only to IBM employees.

@volosied
Create test for MYFACES-4658
bfcf579 
Fix review comments
@LibbyBot
Copy link

LibbyBot commented May 8, 2024

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=ff0eaf0b-78b8-429f-b00c-0e261b4b9c1c has errors/failures.

@LibbyBot
Copy link

LibbyBot commented May 8, 2024

The build volosied-28172-20240507-1212
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_yZdLgAyZEe-d7o-0EQ2ULA
completed successfully!

@volosied
Copy link
Member Author

volosied commented May 8, 2024

#libby

1 similar comment
@volosied
Copy link
Member Author

volosied commented May 8, 2024

#libby

@LibbyBot
Copy link

LibbyBot commented May 8, 2024

The following files contain a string indicating discriminating content:

  • dev/io.openliberty.jakarta.faces.4.0/src/META-INF/resources/jakarta.faces/faces-development.js

1 similar comment
@LibbyBot
Copy link

LibbyBot commented May 8, 2024

The following files contain a string indicating discriminating content:

  • dev/io.openliberty.jakarta.faces.4.0/src/META-INF/resources/jakarta.faces/faces-development.js

@volosied volosied requested a review from pnicolucci May 8, 2024 15:09
@volosied
Copy link
Member Author

volosied commented May 8, 2024

#libby

@LibbyBot
Copy link

LibbyBot commented May 8, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.

WARNING: This pull request contains binary files, which should be managed in a Maven repository.

  • 8 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 12 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

LibbyBot commented May 8, 2024

The following files contain a string indicating discriminating content:

  • dev/io.openliberty.jakarta.faces.4.0/src/META-INF/resources/jakarta.faces/faces-development.js

@volosied volosied merged commit 86cd537 into OpenLiberty:integration May 9, 2024
1 of 2 checks passed
@volosied volosied mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-chacko joe-chacko joe-chacko left review comments

@pnicolucci pnicolucci pnicolucci approved these changes

Assignees

@volosied volosied

Labels
CLA Signed in:Web Components team:Sirius
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port MYFACES-4658
4 participants
@volosied @LibbyBot @joe-chacko @pnicolucci