Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support wildcards #5756

Merged
merged 1 commit into from Nov 15, 2018
Merged

support wildcards #5756

merged 1 commit into from Nov 15, 2018

Conversation

benjamin-confino
Copy link
Contributor

fixes #5755

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • Please describe in a separate comment how you tested your changes.

  • 1 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

@benjamin-confino
Copy link
Contributor Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_9DIzsOgYEeiB5J8_tOvcPQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build benjamin-confino-5756-20181114-1535
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_9DIzsOgYEeiB5J8_tOvcPQ
completed and has errors or failures.

aguibert
aguibert suggested changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@aguibert aguibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the concept of this change, but I would like the wildcard detection to be more tolerant (see previous comment).
Also, please javadoc this so people know about it!

dev/fattest.simplicity/src/componenttest/rules/repeater/FeatureReplacementAction.java Outdated
@@ -347,6 +363,20 @@ private static String getReplacementFeature(String originalFeature, Set<String>
return null;
}

private static boolean removeWildcardFeature(Set<String> features, String removeFeature) {
String matcher = removeFeature.substring(0, removeFeature.length() - 1); //This assumes the feature string is in the format "feature-*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should make this assumption that wildcards are always feature-*, mainly because if I do something slightly different but valid like feature* or feature-1.* it would be tricky to figure out why the features are not being removed.

@benjamin-confino benjamin-confino merged commit b85910a into OpenLiberty:integration Nov 15, 2018
@benjamin-confino benjamin-confino deleted the 5755-FeatureReplaceWildcards branch November 23, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguibert aguibert aguibert approved these changes

Assignees
No one assigned
Labels
CLA Signed noproductcode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FeatureReplacementAction should support removing feature by wildcards
3 participants
@benjamin-confino @LibbyBot @aguibert