-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for connection wait timeout translation #6406
fix for connection wait timeout translation #6406
Conversation
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
@@ -112,7 +112,7 @@ NO_VALID_TRANSACTION_CONTEXT_J2CA0040.explanation=There was an internal error in | |||
NO_VALID_TRANSACTION_CONTEXT_J2CA0040.useraction=CMSG0002 | |||
|
|||
# -------------------------------- | |||
POOL_MANAGER_EXCP_CCF2_0001_J2CA0045=J2CA0045E: Connection not available while invoking method {0} for resource {1}. | |||
POOL_MANAGER_EXCP_CCF2_0001_J2CA0045=J2CA0045E: Connection not available while invoking method {0} for resource {1}. Timed out waiting for {2} millisecond with {3} remaining waiting requests and current total connections used {4}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should milliseconds be plural? I suppose it could also be 1 millisecond. Or maybe millesecond(s)? ID may know what we normally would do here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated adding the (s)
+ " on datasource " | ||
+ gConfigProps.cfName); | ||
} | ||
Object[] connWaitTimeoutparms = new Object[] { "createOrWaitForConnection", gConfigProps.cfName, 0, pm.waiterCount, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the method here be queueRequest instead of createOrWaitForConnection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_HjnmwCl-EemoQsY-pF-VMw Target locations of links might be accessible only to IBM employees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change: instead of "and current total connections used {4}" move the variable forward so the phrase is "and {4} current total connections used"
Your Open Liberty build results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_HjnmwCl-EemoQsY-pF-VMw. There might be a brief delay before results are available. |
The build jmstephensgit-6406-20190205-2050 |
Your Open Liberty build results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_lZNpICoQEemoQsY-pF-VMw. There might be a brief delay before results are available. |
Investigated all test results with none of the failures being related to the changes in the pull request. Merging this pull |
The build jmstephensgit-6406-20190206-1419 |
The connection wait timeout exception text is not translated.
The follow error in the trace and connection wait timeout exception will be translated and contain the same information to better problem determination.
[2/5/18 7:32:35:183 CST] 0000004b id=00000000 com.ibm.ejs.j2c.FreePool E J2CA0045E: Connection not available while invoking method createOrWaitForConnection for resource jdbc/test. Timed out waiting for 20,005 with 3 remaining waiting requests and current total connections used 1.
Exception returned to application,
Caused by: com.ibm.websphere.ce.j2c.ConnectionWaitTimeoutException: J2CA0045E: Connection not available while invoking method createOrWaitForConnection for resource jdbc/test. Timed out waiting for 20,005 with 3 remaining waiting requests and current total connections used 1.