Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multi-release jar classloading #6798

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Implement multi-release jar classloading #6798

merged 1 commit into from
Mar 11, 2019

Conversation

aguibert
Copy link
Contributor

@aguibert aguibert commented Mar 6, 2019

fixes #6790

@LibbyBot
Copy link

LibbyBot commented Mar 6, 2019

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 6 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@aguibert aguibert self-assigned this Mar 6, 2019
@aguibert
Copy link
Contributor Author

aguibert commented Mar 6, 2019

Running a test #build to see if this breaks anything

@LibbyBot
Copy link

LibbyBot commented Mar 6, 2019

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_zxJTQD-hEemZ2MYBJzNhRQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Mar 6, 2019

Your Open Liberty build results are ready for viewing.

@LibbyBot
Copy link

LibbyBot commented Mar 6, 2019

The build aguibert-6798-20190306-0100
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_zxJTQD-hEemZ2MYBJzNhRQ
completed and has errors or failures.

tbitonti
tbitonti requested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@tbitonti tbitonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*) Have the isMR flag set on the first open of the jar file, instead adding a new open call. That will probably mean adding a call from getIsMR() to setZipEntryData.
*) Adjust the call flow from locatePath; the call to locatePath(S) to locatePath(S,b) to locateMRPath(S) back to locatePath(S,b) is strained. I'd rename locatePath(S,b) to 'locateDirectPath' and move the check in the current locatePath(S,b) to locatePath(S).

@aguibert aguibert force-pushed the multi-release-classloading branch 3 times, most recently from 760a3e8 to 9807b90 Compare March 7, 2019 22:43
@aguibert
Copy link
Contributor Author

aguibert commented Mar 7, 2019

#build

@LibbyBot
Copy link

LibbyBot commented Mar 7, 2019

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_QFazU0ElEemZ2MYBJzNhRQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Mar 8, 2019

Your Open Liberty build results are ready for viewing.

@LibbyBot
Copy link

LibbyBot commented Mar 8, 2019

The build aguibert-6798-20190307-2345
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_QFazU0ElEemZ2MYBJzNhRQ
completed and has errors or failures.

@aguibert aguibert requested a review from jhanders34 March 8, 2019 15:21
@aguibert
Copy link
Contributor Author

aguibert commented Mar 8, 2019

#build

@LibbyBot
Copy link

LibbyBot commented Mar 8, 2019

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_IsHjEEHsEemZ2MYBJzNhRQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Mar 9, 2019

Your Open Liberty build results are ready for viewing.

@LibbyBot
Copy link

LibbyBot commented Mar 9, 2019

The build aguibert-6798-20190308-2308
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_IsHjEEHsEemZ2MYBJzNhRQ
completed and has errors or failures.

@aguibert aguibert merged commit 735c2d2 into OpenLiberty:integration Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbitonti tbitonti tbitonti approved these changes

@jhanders34 jhanders34 jhanders34 approved these changes

Assignees

@aguibert aguibert

Labels
CLA Signed in:Application Services team:Zombie Apocalypse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading classes from multi-release jars does not work
4 participants
@aguibert @LibbyBot @jhanders34 @tbitonti