Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for race condition when getting services #9168

Conversation

benjamin-confino
Copy link
Contributor

No description provided.

@LibbyBot
Copy link

LibbyBot commented Oct 2, 2019

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@@ -146,6 +146,7 @@ private static ConfigVariables getConfigVariables(BundleContext bundleContext) t
* @throws InvalidFrameworkStateException if the server OSGi framework is being shutdown
* @throws ServiceNotFoundException if an instance of the requested service can not be found
*/
@FFDCIgnore(InvalidFrameworkStateException.class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all honesty I'm going by the fact it's on a lot of other methods. Though it seems reasonable that we don't want to throw an exception that only occurs during shutdown as it's unlikely to be an issue the customer needs to worry about.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will fail to build ... the build checks that all FFDCIgnore exceptions are caught in the method.

Copy link
Member

@tevans78 tevans78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@benjamin-confino
Copy link
Contributor Author

#build

@LibbyBot
Copy link

LibbyBot commented Oct 8, 2019

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_fMiuMOnAEemoq4hjSBupzg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Oct 8, 2019

@LibbyBot
Copy link

LibbyBot commented Oct 8, 2019

The build benjamin-confino-9168-20191008-1403
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_fMiuMOnAEemoq4hjSBupzg
completed successfully!

@benjamin-confino benjamin-confino merged commit 699e2be into OpenLiberty:integration Oct 9, 2019
@benjamin-confino benjamin-confino deleted the RTC266812-framework-state branch November 17, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants