New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for race condition when getting services #9168
Check for race condition when getting services #9168
Conversation
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
@@ -146,6 +146,7 @@ private static ConfigVariables getConfigVariables(BundleContext bundleContext) t | |||
* @throws InvalidFrameworkStateException if the server OSGi framework is being shutdown | |||
* @throws ServiceNotFoundException if an instance of the requested service can not be found | |||
*/ | |||
@FFDCIgnore(InvalidFrameworkStateException.class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all honesty I'm going by the fact it's on a lot of other methods. Though it seems reasonable that we don't want to throw an exception that only occurs during shutdown as it's unlikely to be an issue the customer needs to worry about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will fail to build ... the build checks that all FFDCIgnore exceptions are caught in the method.
8083603
to
ed8c81f
Compare
ed8c81f
to
b1c7f0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
#build |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_fMiuMOnAEemoq4hjSBupzg Target locations of links might be accessible only to IBM employees. |
Your Open Liberty build results are ready for viewing.
|
The build benjamin-confino-9168-20191008-1403 |
No description provided.