Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float off the code column when at the end of guide #947

Closed
steven1046 opened this issue Feb 1, 2019 · 2 comments
Closed

Float off the code column when at the end of guide #947

steven1046 opened this issue Feb 1, 2019 · 2 comments
Labels
enhancement Improvements to existing functionality; redesigns

Comments

@steven1046
Copy link
Member

We need to float away the code column like the toc and guide column do when scrolling into the end of guide section.

@steven1046 steven1046 self-assigned this Feb 1, 2019
@steven1046 steven1046 assigned ellenwyllie and unassigned steven1046 Feb 25, 2019
@steven1046
Copy link
Member Author

I had attempted this issue on branch Code_Column_Scroll_Away and it partly works but do we want the code tabs to scroll away? It also makes the Circuit breaker playground and other interactive guide playgrounds unusable once the right side starts scrolling out of view.

@steven1046 steven1046 added enhancement Improvements to existing functionality; redesigns and removed multipane labels Mar 4, 2019
@ellenwyllie ellenwyllie removed their assignment Apr 9, 2019
@mbroz2
Copy link
Member

mbroz2 commented Apr 10, 2019

No impact on end user, and large development effort to make changes (also would introduce new issues in interactive guides).

@mbroz2 mbroz2 closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing functionality; redesigns
Projects
None yet
Development

No branches or pull requests

3 participants