Make latestVersion.js update without restart #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1616 Currently the LatestVersion servlet doesn't correctly show an new build without a server restart so this fix aims to resolve that. The fix uses CDI events to notify the change. This necessetated the following changes: 1. BuildData is now a CDI beans which means using setter and getters for JSON-B. 2. BuildData now fires an event if the BuildType is a release. 3. The LatestVersion servlet now observes the event emitted by BuildData 4. The AtomicReference storing the latestVersion.js is now static since CDI events create random new instances for notification. 5. DHEBuildParser now has BuildData injected. 6. Written a test using MicroShed Testing and MockServer to support the updates. This new test won't pass with liberty dev mode though. Not quite sure how to resolve that at this time. 7. Added a pre destroy method to cancel the scheduled futures on shutdown. This means if using dev mode we correctly tidy up when in dev mode rather than relying on Liberty to do it. 8. Renamed the current Dockerfile to Dockerfile blogs since it is there to support building and editing the blog posts 9. Created a new Dockerfile that contains the website code. 10. Added catch blocks for JAX-RS RuntimeExceptions which will prevent retries working.
Support latestVersion.js updating without restart
Add the target/jekyll-webapp back to pom.xml
Fix the JAX-RS endpoint so it only intercepts api requests
NottyCode
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was fixed? (Issue # or description of fix)
Were the changes tested on
Running validation tools