Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDM responder test "server error" when max personality is 255 #1508

Closed
majcit opened this issue Oct 30, 2018 · 42 comments
Closed

RDM responder test "server error" when max personality is 255 #1508

majcit opened this issue Oct 30, 2018 · 42 comments

Comments

@majcit
Copy link

majcit commented Oct 30, 2018

I encountered an issue during OLA responder test,

my device is RGB LED fixture,
I planned to use all 255 different personalities, (1 DMX mode, 254 DEMO mode)

when I run the OLA responder test with 255 personalities, "server error" occures.
when I reduce personality to 254 (1 DMX, 253 DEMO) test passes sucessfully

according to 10.6.1, personality may be 1-255
so I think this "server error" is related to OLA.
ola - server error

@peternewman
Copy link
Member

Hi @majcit ,

I assume this is also you:
http://www.rdmprotocol.org/forums/showthread.php?p=3223

Sorry, I saw and fixed a bug related to this, but hadn't had a chance to reply yet.

My fix is here:
eb7ff0d

However that isn't the resolution to the error you're getting. What version of OLA are you running on what OS and how did you install it?

I think this is the fix for the bug you reported (but I'd still expect it should be fixed in any recent OS):
e44415a

@majcit
Copy link
Author

majcit commented Oct 30, 2018

Hi Peter,
Thanks for reply
Yes It's my thread on RDM forum.

my colleague setup the OLA server a few monthes ago following instructions: https://www.openlighting.org/rdm-tools/rdm-responder-tests/getting-started/#Installation

I should say I have no experience about LINUX , after I struggled command line and found out my LINUX version is 7.11
I have no idea how to get OLA version info

I will try to update OLA but I wonder is there a simple instruction to update , (for dummies!) ?
Would you please give me some clues,

Regards

@peternewman
Copy link
Member

That's a version of Linux released in 2016:
https://www.debian.org/News/2016/2016060402

You can find your Ola version at http://:9090/

Apologies, those docs, like a number of our installation ones, could do with an update. Nowadays you're better following the normal steps to install the latest Raspbian:
https://projects.raspberrypi.org/en/projects/raspberry-pi-getting-started

Then just run:
sudo apt-get install ola-rdm-tests

You could in theory update Raspbian, but starting from scratch will be easier. If you've got another SD card, you can do the new stuff on the second card, so you've even got something to fall back on if you have an issue for some reason.

@majcit
Copy link
Author

majcit commented Oct 31, 2018

ok,
my old OLA version was 0.9.5

I just installed the latest Raspbian and ola-rdm-test. just as you said, very easy thanks so much.
my new Raspbian Ver : 9.4 (stretch)
my new OLA Ver : 0.10.3

now http://10.1.1.12:9090/ola.html works fine , I can do discovery and send dmx data to my LED fixture successfully.

but, http://10.1.1.12:9099/static/rdmtests.html does not work :/
my browser (Chrome) displays access error "ERR_CONNECTION_REFUSED"

did I miss something?


edit:
I have tried 2 hardware :
ENTTEC USB PRO and
ENTTEC USB PRO Mk2
result is the same: 9090 works fine, 9099 does not work

@peternewman
Copy link
Member

Excellent, glad to hear it!

Did you run the OLAd process manually, or was it just working when you browsed to the address?

If you run sudo /etc/init.d/rdm_test_server start on the Pi, then 9099 should work.

This should make it start up automatically each time you restart the Pi:
sudo update-rc.d rdm_test_server defaults

@majcit
Copy link
Author

majcit commented Oct 31, 2018

I executed your last commands :
rdm_test_server - start

9090 works fine, I suspect All IP numbers are 0, but I can discover and change personality of LED fixture, and turn on LEDs using DMX CONSOLE successfully :
9090

9091 not work at all :
9099 - start

@majcit
Copy link
Author

majcit commented Oct 31, 2018

I also tried "rdm_test_server.py" command :
rdm_test_server

after this command opens 9099 page , but does not work, I can not select UNIVERSE or RESPONDER from combobox :
9099

@peternewman
Copy link
Member

peternewman commented Oct 31, 2018

What does dpkg -l | grep -i ola show?

What about sudo /etc/init.d/rdm_test_server status?

Does hitting Ctrl+F5 help, what does the browser console error log show? It feels like some of the Javascript hasn't loaded properly.

This feels like some of the packaging bugs that @yoe fixed haven't made it into Raspbian yet possibly.

@peternewman
Copy link
Member

9090 works fine, I suspect All IP numbers are 0, but I can discover and change personality of LED fixture, and turn on LEDs using DMX CONSOLE successfully :

That's a bit odd. If you do sudo /etc/init.d/olad restart they'll probably show the right IPs.

@yoe
Copy link
Contributor

yoe commented Oct 31, 2018 via email

@majcit
Copy link
Author

majcit commented Oct 31, 2018

ok, after dpkg -l | grep -i ola
dkpg

after sudo /etc/init.d/rdm_test_server status
status

after, sudo /etc/init.d/olad restart :
9090 shows proper IP and works fine as before , 9091 opens but not work:
9090 - 1

@peternewman
Copy link
Member

Can we see the browser console error log for the failing page please @majcit ?

@yoe so that appears to be the same version as Debian, I'd hope it's working in stable there, but I don't know for certain.

@majcit
Copy link
Author

majcit commented Oct 31, 2018

there is no error message,

9091 not opens at all before rdm_test_server.py ,
there is "ERR_CONNECTION_REFUSED" message on browser,
there is no message on prompt

9091 opens after rdm_test_server.py but not work ,
there is no error message

I hope I understand right the meaning of "error log" as you expected, if not please forgive my poor knowlegde about LINUX !

command prompt log is here :
pi@raspberrypi:~ $ rdm_test_server.py Checking olad status Running RDM Tests Server on 127.0.0.1:9099 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/rdmtests.html HTTP/1.1" 200 15619 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/jquery-ui-1.8.21.custom.css HTTP/1.1" 200 33311 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/ui.multiselect.css HTTP/1.1" 200 1886 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/jquery.min.js HTTP/1.1" 200 135993 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/jquery-ui.custom.min.js HTTP/1.1" 404 0 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/ui.multiselect.js HTTP/1.1" 200 11024 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/rdm_tests.js HTTP/1.1" 200 29800 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/images/logo.png HTTP/1.1" 200 1579 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/images/discovery.png HTTP/1.1" 200 860 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/jquery-ui.custom.min.js HTTP/1.1" 404 0 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/images/external.png HTTP/1.1" 200 165 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /favicon.ico HTTP/1.1" 301 0 10.1.0.158 - - [31/Oct/2018 17:58:23] "GET /static/images/favicon.ico HTTP/1.1" 200 1406


is 127.0.0.1:9099 normal at first line above ?
whille my OLA home is 10.1.1.12:9090 and I expect OLA rdm tester to be 10.1.1.12:9099

Running RDM Tests Server on 127.0.0.1:9099

@yoe
Copy link
Contributor

yoe commented Oct 31, 2018

The rdm_test_server status thing shows that it's not actually running. It says active (exited), which is due to the fact that sysv support in systemd is not entirely complete.

This is indeed due to the bug in Debian. I'll see if I can push an update for that; it's pretty stupid.

Meanwhile, you can edit /etc/init.d/rdm_test_server and fix the DAEMON_ARGS line, like the bug report says, then restart it. That should fix it.

@peternewman
Copy link
Member

I hope I understand right the meaning of "error log" as you expected, if not please forgive my poor knowlegde about LINUX !

I was actually meaning within your web browser you should be able to run diagnostic tools or similar and see a console or error log there, however your log had given enough to go on.

is 127.0.0.1:9099 normal at first line above ?
whille my OLA home is 10.1.1.12:9090 and I expect OLA rdm tester to be 10.1.1.12:9099

Running RDM Tests Server on 127.0.0.1:9099

Yes, that's intended, we actually bind to 0.0.0.0, so you can access it from any IPs your machine has (e.g. WiFi and wired), but that doesn't make much sense to report, so instead we display the localhost address.

@peternewman
Copy link
Member

The rdm_test_server status thing shows that it's not actually running. It says active (exited), which is due to the fact that sysv support in systemd is not entirely complete.

This is indeed due to the bug in Debian. I'll see if I can push an update for that; it's pretty stupid.

That will fix it not starting from the init script @yoe although he's also running it manually which is serving up pages but still not working.

However this log line is the key:
[31/Oct/2018 17:58:23] "GET /static/jquery-ui.custom.min.js HTTP/1.1" 404 0 10.1.0.158 - -

I think this is another consequence of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760414 and Debian policy. Specifically https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790886 , it looks like in both Stretch and Sid, the symlink is from /usr/share/ola/rdm-server/jquery-ui.min.js, but the HTML has only had the version stripped off, not the custom bit (which presumably hopefully just optimised it/removed stuff not being used in that GUI).

I don't know how long a release cycle takes for you, but stretch is a no brainer I'd hope. However I'm hoping to release 0.10.8 imminently (I just need to do the NEWS, although I may add the other spelling of writeable too as I'd promised before), so it might possibly make sense to wait a bit for whichever one a new release would appear in.

You should be able to test the test server functionality on a test box by patching the dummy plugin to a universe and then running the test server against one of our dummy responders (they should pass all the tests of course!).

@majcit
Copy link
Author

majcit commented Nov 1, 2018

I installed an older version of Raspbian V9 :

pi@raspberrypi:~ $ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

no succeed :/
9090 works fine,
9099 open page but not work (not open UNIVERSE combo box nor RDM Responder combo box)

You should be able to test the test server functionality on a test box by patching the dummy plugin to a universe and then running the test server against one of our dummy responders (they should pass all the tests of course!).

for Enttec Usb Pro Device :

pi@raspberrypi:~ $ rdm_test_server.py
Checking olad status
Running RDM Tests Server on 127.0.0.1:9099
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/rdmtests.html HTTP/1.1" 200 15619
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/jquery-ui-1.8.21.custom.css HTTP/1.1" 200 33311
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/ui.multiselect.css HTTP/1.1" 200 1886
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/jquery.min.js HTTP/1.1" 200 135993
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/jquery-ui.custom.min.js HTTP/1.1" 404 0
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/ui.multiselect.js HTTP/1.1" 200 11024
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/rdm_tests.js HTTP/1.1" 200 29800
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/images/logo.png HTTP/1.1" 200 1579
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/images/discovery.png HTTP/1.1" 200 860
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/jquery-ui.custom.min.js HTTP/1.1" 404 0
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/images/external.png HTTP/1.1" 200 165
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /favicon.ico HTTP/1.1" 301 0
10.1.0.158 - - [01/Nov/2018 07:36:46] "GET /static/images/favicon.ico HTTP/1.1" 200 1406

for Dummy Device :

pi@raspberrypi:~ $ rdm_test_server.py
Checking olad status
Running RDM Tests Server on 127.0.0.1:9099
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/rdmtests.html HTTP/1.1" 200 15619
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/jquery-ui-1.8.21.custom.css HTTP/1.1" 200 33311
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/ui.multiselect.css HTTP/1.1" 200 1886
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/jquery.min.js HTTP/1.1" 200 135993
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/jquery-ui.custom.min.js HTTP/1.1" 404 0
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/ui.multiselect.js HTTP/1.1" 200 11024
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/rdm_tests.js HTTP/1.1" 200 29800
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/images/logo.png HTTP/1.1" 200 1579
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/images/discovery.png HTTP/1.1" 200 860
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/images/external.png HTTP/1.1" 200 165
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /favicon.ico HTTP/1.1" 301 0
10.1.0.158 - - [01/Nov/2018 07:40:04] "GET /static/images/favicon.ico HTTP/1.1" 200 1406

@peternewman
Copy link
Member

I installed an older version of Raspbian V9 :

Sorry @majcit that was directed at @yoe rather than you.

You should be able to test the test server functionality on a test box by patching the dummy plugin to a universe and then running the test server against one of our dummy responders (they should pass all the tests of course!).

As was that.

If you go back to the latest version of Raspbian and edit /usr/share/ola/rdm-server/rdmtests.html, you should find jquery-ui.custom.min.js in that file; change it to jquery-ui.min.js, then it should start working as intended.

@majcit
Copy link
Author

majcit commented Nov 1, 2018

sadly I have to return back and content with OLA 0.9.5 till new release of OLA 0.10.8

I should say binary package image http://dl.openlighting.org/raspbian-ola-0.9.5.zip
is very easy to use and practical to set up RDM test server.

I kindly request if possible please prepare similar method for new versions.

thank you so much
regards

@majcit
Copy link
Author

majcit commented Nov 2, 2018

If you go back to the latest version of Raspbian and edit /usr/share/ola/rdm-server/rdmtests.html, you should find jquery-ui.custom.min.js in that file; change it to jquery-ui.min.js, then it should start working as intended.

I tried to run test over Dummy device, I did as following :
setup the new Raspbian ver 9 and update it
installed OLA ver 10.3
I have changed the "rdmtests.html" content as you said above

the result:
9090 works fine as before, on Enttec Usb Pro

9099 opens page,
combo boxes works fine, I can select Dummy univers and devices.
I can select all 426 test
but RUN TEST button does not work (shows reflex to click), but test does not start

pi@raspberrypi:~ $ rdm_test_server.py
Checking olad status
Running RDM Tests Server on 127.0.0.1:9099
10.1.0.165 - - [02/Nov/2018 09:27:27] "GET /static/rdmtests.html HTTP/1.1" 200 15612
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/jquery-ui-1.8.21.custom.css HTTP/1.1" 200 33311
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/ui.multiselect.css HTTP/1.1" 200 1886
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/jquery.min.js HTTP/1.1" 200 135993
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/jquery-ui.min.js HTTP/1.1" 200 312860
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/ui.multiselect.js HTTP/1.1" 200 11024
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/rdm_tests.js HTTP/1.1" 200 29800
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/logo.png HTTP/1.1" 200 1579
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/discovery.png HTTP/1.1" 200 860
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/external.png HTTP/1.1" 200 165
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/ui-bg_glass_60_eeeeee_1x400.png HTTP/1.1" 200 110
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/ui-bg_inset-hard_75_999999_1x100.png HTTP/1.1" 200 114
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/ui-bg_inset-soft_50_c9c9c9_1x100.png HTTP/1.1" 200 96
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/ui-bg_glass_35_dddddd_1x400.png HTTP/1.1" 200 109
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/ui-icons_999999_256x240.png HTTP/1.1" 200 4369
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /GetUnivInfo?_=1541140047691 HTTP/1.1" 200 79
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /GetTestDefs?c=0&_=1541140047692 HTTP/1.1" 200 11693
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /favicon.ico HTTP/1.1" 301 0
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /GetDevices?u=2&_=1541140047693 HTTP/1.1" 200 128
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/ui-icons_70b2e1_256x240.png HTTP/1.1" 200 4369
10.1.0.165 - - [02/Nov/2018 09:27:28] "GET /static/images/favicon.ico HTTP/1.1" 200 1406
10.1.0.165 - - [02/Nov/2018 09:27:37] "GET /static/images/ui-bg_glass_100_f8f8f8_1x400.png HTTP/1.1" 200 105
10.1.0.165 - - [02/Nov/2018 09:27:37] "GET /static/images/ui-icons_3383bb_256x240.png HTTP/1.1" 200 4369

dummy

@yoe
Copy link
Contributor

yoe commented Nov 3, 2018

FYI, I've just uploaded an update for ola in Debian stable that fixes these issues. It should be part of an upcoming point release. There is one planned for next weekend, but I believe I'm too late for that one already.

@majcit
Copy link
Author

majcit commented Nov 3, 2018

👍
glad to hear, thanks. I can't wait to see it.
Maybe I go to workplace tomorrow to test it.

İs new update available for users (me) now?
Or shall I wait the official release?

@yoe
Copy link
Contributor

yoe commented Nov 4, 2018

No, you need to wait until it is in Debian stable. You can check the tracking bug in the Debian bts to see when that's done; it will be marked as 'closed' when the updated package is included and available.

@yoe
Copy link
Contributor

yoe commented Nov 4, 2018

(also, if you're using Raspbian, you may need to wait until the update of Raspbian that includes it... Don't know what their exact policies on that subject are, but they're usually reasonably fast with that)

@yoe
Copy link
Contributor

yoe commented Nov 4, 2018 via email

@peternewman
Copy link
Member

I should say binary package image http://dl.openlighting.org/raspbian-ola-0.9.5.zip
is very easy to use and practical to set up RDM test server.

I kindly request if possible please prepare similar method for new versions.

See here for discussion on updating those:
#1212

In short I'm going to prioritise writing code myself, but others are welcome to work on building Pi images and keeping them up to date.

@peternewman
Copy link
Member

If you go back to the latest version of Raspbian and edit /usr/share/ola/rdm-server/rdmtests.html, you should find jquery-ui.custom.min.js in that file; change it to jquery-ui.min.js, then it should start working as intended.

I tried to run test over Dummy device, I did as following :
setup the new Raspbian ver 9 and update it
installed OLA ver 10.3
I have changed the "rdmtests.html" content as you said above

the result:
9090 works fine as before, on Enttec Usb Pro

9099 opens page,
combo boxes works fine, I can select Dummy univers and devices.
I can select all 426 test
but RUN TEST button does not work (shows reflex to click), but test does not start

Can we see the browser's console log for that bit please @majcit ? I take it you had added the tests too, so they move from right to left as per your screenshot?

FYI, I've just uploaded an update for ola in Debian stable that fixes these issues. It should be part of an upcoming point release. There is one planned for next weekend, but I believe I'm too late for that one already.

Just to confirm @yoe did you actually run tests against the dummy responders to confirm the run button (and test results) worked too?

On Wed, Oct 31, 2018 at 07:52:10PM -0700, Peter Newman wrote: You should be able to test the test server functionality on a test box by patching the dummy plugin to a universe and then running the test server against one of our dummy responders (they should pass all the tests of course!).
Is this something we can do from the command line? If so, might make sense to add that to an autopkgtest in the Debian package...

Yes, and yes, was on my list (and still is), maybe doing a basic one that just tests one responder would be a good start (although wouldn't catch this specific issue unless we do webpage stuff too). We need to launch olad (how do we do that in autopkgtest) then run: http://docs.openlighting.org/ola/man/man1/rdm_responder_test.py.1.html

@majcit
Copy link
Author

majcit commented Nov 8, 2018

but RUN TEST button does not work (shows reflex to click), but test does not start

Can we see the browser's console log for that bit please @majcit ? I take it you had added the tests too, so they move from right to left as per your screenshot?

Today I reinstalled a fresh Raspbian V9 and OLA V0.10.3 from scratch and repeat the instructions again:
-change jquery-ui.custom.min.js to jquery-ui.min.js
-command rdm_test_server.py
-select dummy port
-select responder
-add all tests

same result : RUN button does not start. :/

here is the log :
pi@raspberrypi:~ $ rdm_test_server.py Checking olad status Running RDM Tests Server on 127.0.0.1:9099 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/rdmtests.html HTTP/1.1" 200 15612 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/jquery-ui-1.8.21.custom.css HTTP/1.1" 200 33311 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/ui.multiselect.css HTTP/1.1" 200 1886 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/jquery.min.js HTTP/1.1" 200 135993 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/jquery-ui.min.js HTTP/1.1" 200 312860 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/ui.multiselect.js HTTP/1.1" 200 11024 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/rdm_tests.js HTTP/1.1" 200 29800 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/images/logo.png HTTP/1.1" 200 1579 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/images/discovery.png HTTP/1.1" 200 860 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/images/external.png HTTP/1.1" 200 165 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/images/ui-bg_glass_60_eeeeee_1x400.png HTTP/1.1" 200 110 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/images/ui-bg_inset-hard_75_999999_1x100.png HTTP/1.1" 200 114 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/images/ui-bg_inset-soft_50_c9c9c9_1x100.png HTTP/1.1" 200 96 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/images/ui-bg_glass_35_dddddd_1x400.png HTTP/1.1" 200 109 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/images/ui-icons_999999_256x240.png HTTP/1.1" 200 4369 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /GetUnivInfo?_=1541686482989 HTTP/1.1" 200 79 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /GetTestDefs?c=0&_=1541686482990 HTTP/1.1" 200 11693 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /favicon.ico HTTP/1.1" 301 0 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /GetDevices?u=0&_=1541686482991 HTTP/1.1" 200 128 10.1.0.187 - - [08/Nov/2018 17:14:44] "GET /static/images/ui-icons_70b2e1_256x240.png HTTP/1.1" 200 4369 10.1.0.187 - - [08/Nov/2018 17:14:45] "GET /static/images/favicon.ico HTTP/1.1" 200 1406 10.1.0.187 - - [08/Nov/2018 17:14:51] "GET /static/images/ui-bg_flat_0_eeeeee_40x100.png HTTP/1.1" 200 180 10.1.0.187 - - [08/Nov/2018 17:14:51] "GET /RunDiscovery?u=0&_=1541686482992 HTTP/1.1" 200 128 10.1.0.187 - - [08/Nov/2018 17:14:51] "GET /static/images/loader.gif HTTP/1.1" 200 3208

@peternewman
Copy link
Member

Please can we see the browser's console/error log @majcit ? E.g. developer tools. If you let us know which browser, we can give you some assistance. There will be some sort of Javascript error occurring when you click the button.

@majcit
Copy link
Author

majcit commented Nov 9, 2018

I use Chrome , Win7 , as I find instruction from internet , the error log file must be created in as below :
cmd: chrome --enable-logging --v=1
in C:\Program Files (x86)\Google\Chrome\Application
but not created , then I tried to reach IE log file but not succeed yet,

BTW I noticed when I changed jquery-ui.custom.min.js to jquery-ui.min.js the caption of the RUN button is also changed as below:

with original jquery-ui.custom.min.js :
image

after change to jquery-ui.min.js :
image

@peternewman
Copy link
Member

I use Chrome , Win7 , as I find instruction from internet , the error log file must be created in as below :
cmd: chrome --enable-logging --v=1
in C:\Program Files (x86)\Google\Chrome\Application
but not created , then I tried to reach IE log file but not succeed yet,

You want this one @majcit :
https://developers.google.com/web/tools/chrome-devtools/console/

Yes, the styling would be intentional and shows the JS is now loading.

@majcit
Copy link
Author

majcit commented Nov 10, 2018

ok , finally I learned how to open error log for Chrome.
It is just as simple as press "F12" then click "console" ! :'(

and here is the error log when I press "RUN TEST" button :

rdm_tests.js:774 Uncaught TypeError: $(...).size is not a function
at RDMTests.validate_form (rdm_tests.js:774)
at HTMLButtonElement.<anonymous> (rdm_tests.js:220)
at HTMLButtonElement.dispatch (jquery.min.js:3)
at HTMLButtonElement.elemData.handle (jquery.min.js:2)

This error occurs in both if I "add all" test items, also when I dont add any test item.

@peternewman
Copy link
Member

Excellent, glad you've discovered the joys of the browser console log.

@majcit (and indeed @yoe ) these fixes should make it actually work with the later JQuery Debian provides:
https://github.com/OpenLightingProject/ola/pull/1324/files

@majcit
Copy link
Author

majcit commented Nov 10, 2018

thanks Peter ,
well the latest Raspbian just released yesterday , it seems long time for next release.

maybe this is silly question but my big question is how other people use new versions of OLA rdm tester, since as I understand >the only< downloadable and working OLA is 0.9.5
How does later versions next to 0.9.5 of OLA work (maybe 0.10.2, or 0.10.1 etc) ?

@majcit
Copy link
Author

majcit commented Nov 11, 2018

https://github.com/OpenLightingProject/ola/pull/1324/files

Does that mean I can modify this java script content and change these 11 items to get result?

I think I misunderstood the previous post that I have to wait till new release of Raspbian.

@peternewman
Copy link
Member

peternewman commented Nov 11, 2018

maybe this is silly question but my big question is how other people use new versions of OLA rdm tester, since as I understand >the only< downloadable and working OLA is 0.9.5

You're only referring to the deb packages from Debian/Raspbian/Ubuntu. Any of those prior to 0.9.1 would have been fine, and possibly anything before 0.10.3.nojsmin-1. Other OSes weren't affected by these bugs (as we bundle our own older JQuery, which works with our code (although could theoretically have issues on newer browsers).

How does later versions next to 0.9.5 of OLA work (maybe 0.10.2, or 0.10.1 etc) ?

Personally I run the bleeding edge git master version, as that's where I develop and I always like to run the latest tests against any fixture. However as you'll have seen with your initial 255 personalities issue (fixed in eb7ff0d), there is always a chance of an issue slipping through. By it's nature its rather challenging to test a test suite.

https://github.com/OpenLightingProject/ola/pull/1324/files
Does that mean I can modify this java script content and change these 11 items to get result?

Yes, you can even apply this diff file using patch:
https://patch-diff.githubusercontent.com/raw/OpenLightingProject/ola/pull/1324.diff

I think I misunderstood the previous post that I have to wait till new release of Raspbian.

You won't need to wait for a full Raspbian release, just for them to update from Debian and release an updated version of that package (once @yoe incorporates these fixes and they make it into the relevant Debian release). Because these files are plain text and interpreted, you can just edit them now and the fixes will work, although if you reinstall it, you'll need to apply the same fixes.

@yoe
Copy link
Contributor

yoe commented Nov 11, 2018 via email

@majcit
Copy link
Author

majcit commented Nov 12, 2018

thanks for complete explanations. I suceeded updating both :
https://github.com/OpenLightingProject/ola/pull/1324/files
and
eb7ff0d

It works fine with dummy devices and my device when Max Personalities < 255
glad to have the latest working rdm responder test package : )

but my device when Max Personalities = 255 "server error" still exists.

my device with max personality < 255 passes all tests successfully :

Broken	Failed	Not Run	Passed	Total
0	0	59	367	426
Results By Category
Configuration8 / 8  (100%)
Control20 / 20  (100%)
Core Functionality4 / 4  (100%)
DMX512 Setup23 / 23  (100%)
Dimmer Settings13 / 13  (100%)
Display Settings2 / 2  (100%)
Error Conditions165 / 165  (100%)
IP and DNS Configuration5 / 5  (100%)
Network Management24 / 24  (100%)
Power / Lamp Settings10 / 10  (100%)
Product Information18 / 18  (100%)
RDM Information0 / 0  -
Sensors6 / 6  (100%)
Status Collection3 / 3  (100%)
Sub Devices65 / 65  (100%)
Unclassified1 / 1  (100%)

same device with max personality = 255 , starts test, at progress bar less than %50 server error occurs :

Server Error
An error has occured: ''GetOutOfRangePersonalityDescription' object has no attribute 'LABEL''
Traceback (most recent call last):
  File "/usr/bin/rdm_test_server.py", line 274, in _RunTests
    tests, device = runner.RunTests(test_filter, False, self._UpdateStats)
  File "/usr/lib/python2.7/dist-packages/ola/testing/rdm/TestRunner.py", line 333, in RunTests
    test.Run()
  File "/usr/lib/python2.7/dist-packages/ola/testing/rdm/ResponderTest.py", line 255, in Run
    super(ResponderTestFixture, self).Run()
  File "/usr/lib/python2.7/dist-packages/ola/testing/rdm/ResponderTest.py", line 196, in Run
    self.Test()
  File "/usr/lib/python2.7/dist-packages/ola/testing/rdm/TestMixins.py", line 934, in Test
    self.SetNotRun('All %s are supported' % self.LABEL)
AttributeError: 'GetOutOfRangePersonalityDescription' object has no attribute 'LABEL'
Please report this bug so it can be fixed. Clicking 'Report Bug' will open a new window and prompt you to sign in with your Google account. Only the information you see here will be sent.

@peternewman
Copy link
Member

peternewman commented Nov 12, 2018

On Sun, Nov 11, 2018 at 08:21:55AM -0800, Peter Newman wrote: I think I misunderstood the previous post that I have to wait till new release of Raspbian. You won't need to wait for a full Raspbian release, just for them to update from Debian and release an updated version of that package
Well, that does require a full Debian point release, which implies a full new Raspbian release :-)

Ah, I didn't realise that, I assumed the fixes just appeared when you release the package given the steady stream of updates I get offered on my normal machine (or is this confusion between you releasing a full new version to stable/unstable and a fix getting backported to an older release)?

thanks for complete explanations. I suceeded updating both :
https://github.com/OpenLightingProject/ola/pull/1324/files
and
eb7ff0d

Excellent, glad you got it sorted.

It works fine with dummy devices and my device when Max Personalities < 255
glad to have the latest working rdm responder test package : )

This isn't the latest working package, it's fixes to make the latest deb package released for your OS function correctly.

Server Error
An error has occured: ''GetOutOfRangePersonalityDescription' object has no attribute 'LABEL''
Traceback (most recent call last):
  File "/usr/bin/rdm_test_server.py", line 274, in _RunTests
    tests, device = runner.RunTests(test_filter, False, self._UpdateStats)
  File "/usr/lib/python2.7/dist-packages/ola/testing/rdm/TestRunner.py", line 333, in RunTests
    test.Run()
  File "/usr/lib/python2.7/dist-packages/ola/testing/rdm/ResponderTest.py", line 255, in Run
    super(ResponderTestFixture, self).Run()
  File "/usr/lib/python2.7/dist-packages/ola/testing/rdm/ResponderTest.py", line 196, in Run
    self.Test()
  File "/usr/lib/python2.7/dist-packages/ola/testing/rdm/TestMixins.py", line 934, in Test
    self.SetNotRun('All %s are supported' % self.LABEL)
AttributeError: 'GetOutOfRangePersonalityDescription' object has no attribute 'LABEL'
Please report this bug so it can be fixed. Clicking 'Report Bug' will open a new window and prompt you to sign in with your Google account. Only the information you see here will be sent.

Sorry about that @majcit . I probably only tested against our git master and then backported the fix, or possibly only tested the test you'd initially reported as failing. Our git master has had a bit of a rewrite in this area of tests, so it masked that issue (as well as catching if this particular bug happens in our test programming), anyway this will fix that particular (and hopefully final) bug:
#1511

@majcit
Copy link
Author

majcit commented Nov 12, 2018

ok,
after #1511 it is fixed ! : )
thank you very much Peter.

and maybe my last question :
when I install a fresh ola RDM responder tester sudo apt-get install ola-rdm-tests
it gets V 0.10.3 for me but I see there is V0.10.7 in release list https://github.com/OpenLightingProject/ola/releases .
do I overlook somthing ?

@peternewman
Copy link
Member

ok,
after #1511 it is fixed ! : )
thank you very much Peter.

Excellent, glad to hear it!

and maybe my last question :
when I install a fresh ola RDM responder tester sudo apt-get install ola-rdm-tests
it gets V 0.10.3 for me but I see there is V0.10.7 in release list https://github.com/OpenLightingProject/ola/releases .
do I overlook somthing ?

What does lsb_release -a show for you? The OLA releases page is the versions as released by the Open Lighting Project, the OSes (in this case Debian/Raspbian) then need to do any packaging changes their end and release those versions (so when 0.10.8 comes out imminently, there will be a (hopefully short) delay before that gets into a version of Debian once @yoe has worked his magic. However they generally value stability over bleeding edge, so you'd probably need to wait for the next Debian/Raspbian release before 0.10.8 (or later) appears.

Alternatively you could compile from scratch, or make your own deb or switch to a different OS (e.g. Arch offers git versions: https://aur.archlinux.org/packages/ola-git/ ).

So I think I'm right in saying you're happy and this can be closed as far as you are concerned @majcit ?

@yoe I assume you'll track merging the outstanding bits to fix oldstable etc in Debian's PTS so you don't need this open either? I'll wait for #1511 to be merged before closing anyway.

@majcit
Copy link
Author

majcit commented Nov 13, 2018

What does lsb_release -a show for you?

pi@raspberrypiOLA:~ $ lsb_release -a
No LSB modules are available.
Distributor ID: Raspbian
Description:    Raspbian GNU/Linux 9.4 (stretch)
Release:        9.4
Codename:       stretch

Thanks so much again. I will wait new release 0.10.8 : )

So I think I'm right in saying you're happy and this can be closed as far as you are concerned @majcit ?

sure I am very happy , I learned new things during this thread. and I got much more than I expected.
I would like to summerize the solution for my later reference and maybe for other users:


To setup RDM Responder Tester 0.10.3 on Raspberry Pi :

  1. download and flash latest Raspbian https://www.raspberrypi.org/downloads/raspbian/
  2. root@raspberrypi:~#sudo apt-get update
  3. root@raspberrypi:~#sudo apt-get upgrade
  4. root@raspberrypi:~#sudo apt-get install ola-rdm-tests
  5. patch : root@raspberrypi:~# cd /usr/share/ola/rdm-server/rdm_tests.js
    https://github.com/OpenLightingProject/ola/pull/1324/files
  6. patch : root@raspberrypi:~# cd /usr/lib/python2.7/dist-packages/ola/testing/rdm/TestDefinitions.py
    eb7ff0d
    and
    dcd5f11
  7. root@raspberrypi:~# sudo update-rc.d rdm_test_server defaults

many thanks to all establishers, engineers and developers of OLA. It is definitly a great tool.
regards

@majcit majcit closed this as completed Nov 17, 2018
@peternewman peternewman added this to the 0.10.8 milestone Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants