New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRC error when sensor description > 25 chars #1551
Comments
Hi @MaartenSp , Can we have some logs please, both olad -l 4 ( https://www.openlighting.org/ola/get-help/ola-faq/#How_do_I_get_olad_-l_4_logs ) and if you run just that RDM test via the rdm_responder_test.py with debug turned on (i.e. using -d and -t): What dongle/interface are you using? What's the responder (is it one you've written yourself)? Can you also try using ola_rdm_get with --frames and -l 4: Which version of OLA, which OS etc? |
oladLog.txt Hi @peternewman , Thanks for your reply. I added the following:
We are running OLA version 10.7, on Raspbian Stretch Light, kernel version 4.14. The responder is one we're currently developing. We are using an ENTTEC DMXUSB PRO interface. In the ola_rdm_get_log file I added the faulty case (26 chars) and a passing case (25 characters). Please let me know if you need any additional info. |
Thank you @peternewman. The command to display the raw RDM frames made debugging a lot easier and pointed me in the right direction, The problem was in the responder and is solved now. This issue may be closed. Thanks for your help! |
Excellent, glad you've sorted it @MaartenSp and that you found the raw frames helpful. For future reference, would you care to tell us the "other controllers, which also check CRC, and they work fine for the case mentioned before.", just so we can be aware they're perhaps not as thorough as expected. In terms of developing fixtures, you might also find this useful, it does the maths for you, (and the other bits under the tools menu): |
The problem did not always reproduce, even with the ola_rdm_get command I got different results in each run. The controller I used most was the NA MasterFade, which did not show the problem, but that is not a 100% guarantee that the controller is less thorough. I also used a Swisson XMT-350, which worked fine. Thanks for the link to the RDM packet dissector, it's a convenient tool and could be useful in the future :) |
Thanks @MaartenSp . Interesting, I'd expect the Swisson to have caught it or to have at least warned you. |
I have the following situation:
In this case, when one of the sensor description contains more than 25 characters, the description is not displayed. When I run the rdm tests and run GetSensorDefinition there, I see an invalid CRC error for the sensors containing more than 25 characters in the description. The other ones are fine. According to RDM standards, a sensor description should be able to contain 32 characters.
I checked with other controllers, which also check CRC, and they work fine for the case mentioned before.
The text was updated successfully, but these errors were encountered: