OLA is crashing on adding Artnet Universe #1726
Comments
|
Hmm, I can't reproduce, although on an older OS. Some questions/requests: |
|
Hi, I am sorry, after installing python-numpy and rebuilding, OLA ist working nice now. Thanks! |
|
I'm glad you fixed it @freaknils , but that's still not good. Does it reliably break without python-numpy? It shouldn't affect it if you're using our main web UI, but perhaps we have a bug. Or does it just randomly fail sometimes if you do a |
|
I could reproduce this reliably using both old and new UI with Arch Linux after someone reported this on AUR. I created that package in the first place just to have libola available for building another tool, so I always ignored the failing tests, and never used OLA in production (yet). gcc 12.1.0 Test suite summaryPASS: common/base/CredentialsTester PASS: common/base/FlagsTester PASS: common/base/LoggingTester PASS: common/dmx/RunLengthEncoderTester PASS: common/export_map/ExportMapTester PASS: common/file/UtilTester PASS: common/io/DescriptorTester PASS: common/io/IOQueueTester PASS: common/io/IOStackTester PASS: common/io/MemoryBlockTester ./config/test-driver: line 112: 344003 Aborted (core dumped) "$@" >> "$log_file" 2>&1 FAIL: common/io/SelectServerTester PASS: common/io/StreamTester ./config/test-driver: line 112: 344070 Aborted (core dumped) "$@" >> "$log_file" 2>&1 FAIL: common/io/TimeoutManagerTester PASS: common/messaging/DescriptorTester PASS: common/network/HealthCheckedConnectionTester PASS: common/network/NetworkTester PASS: common/network/TCPConnectorTester PASS: common/rdm/DiscoveryAgentTester PASS: common/rdm/PidStoreTester PASS: common/rdm/QueueingRDMControllerTester PASS: common/rdm/RDMAPITester PASS: common/rdm/RDMCommandSerializerTester PASS: common/rdm/RDMCommandTester PASS: common/rdm/RDMFrameTester PASS: common/rdm/RDMHelperTester PASS: common/rdm/RDMMessageTester PASS: common/rdm/RDMReplyTester PASS: common/rdm/UIDAllocatorTester PASS: common/rdm/UIDTester PASS: common/rpc/RpcTester PASS: common/rpc/RpcServerTester PASS: common/strings/UtilsTester PASS: common/thread/ExecutorThreadTester PASS: common/thread/ThreadTester PASS: common/thread/FutureTester PASS: common/timecode/TimeCodeTester PASS: common/utils/UtilsTester PASS: common/web/JsonTester PASS: common/web/ParserTester PASS: common/web/PtchParserTester PASS: common/web/PtchTester PASS: common/web/PointerTester PASS: common/web/PointerTrackerTester PASS: common/web/SchemaParserTester PASS: common/web/SchemaTester PASS: common/web/SectionsTester PASS: data/rdm/PidDataTester PASS: libs/acn/E131Tester PASS: libs/acn/E133Tester PASS: libs/acn/TransportTester PASS: libs/usb/LibUsbThreadTester PASS: ola/OlaClientTester PASS: olad/plugin_api/ClientTester PASS: olad/plugin_api/DeviceTester PASS: olad/plugin_api/DmxSourceTester PASS: olad/plugin_api/PortTester PASS: olad/plugin_api/PreferencesTester PASS: olad/plugin_api/UniverseTester ./config/test-driver: line 112: 345501 Aborted (core dumped) "$@" >> "$log_file" 2>&1 FAIL: plugins/artnet/ArtNetTester PASS: plugins/dummy/DummyPluginTester PASS: plugins/espnet/EspNetTester PASS: plugins/kinet/KiNetTester PASS: plugins/openpixelcontrol/OPCClientTester PASS: plugins/openpixelcontrol/OPCServerTester PASS: plugins/osc/OSCTester PASS: plugins/shownet/ShowNetTester PASS: plugins/spi/SPITester PASS: plugins/usbpro/ArduinoWidgetTester PASS: plugins/usbpro/BaseRobeWidgetTester PASS: plugins/usbpro/BaseUsbProWidgetTester PASS: plugins/usbpro/DmxTriWidgetTester ./config/test-driver: line 112: 345880 Aborted (core dumped) "$@" >> "$log_file" 2>&1 FAIL: plugins/usbpro/DmxterWidgetTester PASS: plugins/usbpro/EnttecUsbProWidgetTester PASS: plugins/usbpro/RobeWidgetDetectorTester PASS: plugins/usbpro/RobeWidgetTester PASS: plugins/usbpro/UltraDMXProWidgetTester PASS: plugins/usbpro/UsbProWidgetDetectorTester ./config/test-driver: line 112: 346087 Aborted (core dumped) "$@" >> "$log_file" 2>&1 FAIL: plugins/usbpro/WidgetDetectorThreadTester PASS: olad/OlaTester PASS: tools/ola_trigger/ActionTester echo "PYTHONPATH=./python PIDDATA=./data/rdm /usr/bin/python ./data/rdm/PidDataTest.py; exit \$?" > data/rdm/PidDataTest.sh chmod +x data/rdm/PidDataTest.sh PASS: data/rdm/PidDataTest.sh echo "for FILE in ./examples/testdata/dos_line_endings ./examples/testdata/multiple_unis ./examples/testdata/partial_frames ./examples/testdata/single_uni ./examples/testdata/trailing_timeout; do echo \"Checking \$FILE\"; ./examples/ola_recorder --verify \$FILE; STATUS=\$?; if [ \$STATUS -ne 0 ]; then echo \"FAIL: \$FILE caused ola_recorder to exit with status \$STATUS\"; exit \$STATUS; fi; done; exit 0" > examples/RecorderVerifyTest.sh chmod +x examples/RecorderVerifyTest.sh PASS: examples/RecorderVerifyTest.sh mkdir -p ./python/ola/rpc echo "PYTHONPATH=./python /usr/bin/python ./python/ola/rpc/SimpleRpcControllerTest.py; exit \$?" > ./python/ola/rpc/SimpleRpcControllerTest.sh chmod +x ./python/ola/rpc/SimpleRpcControllerTest.sh PASS: python/ola/rpc/SimpleRpcControllerTest.sh PASS: python/ola/DUBDecoderTest.py mkdir -p ./python/ola echo "PYTHONPATH=./python /usr/bin/python ./python/ola/ClientWrapperTest.py; exit \$?" > ./python/ola/ClientWrapperTest.sh chmod +x ./python/ola/ClientWrapperTest.sh FAIL: python/ola/ClientWrapperTest.sh PASS: python/ola/MACAddressTest.py mkdir -p ./python/ola echo "PYTHONPATH=./python /usr/bin/python ./python/ola/OlaClientTest.py; exit \$?" > ./python/ola/OlaClientTest.sh chmod +x ./python/ola/OlaClientTest.sh PASS: python/ola/OlaClientTest.sh mkdir -p ./python/ola echo "PYTHONPATH=./python TESTDATADIR=./common/rdm/testdata /usr/bin/python ./python/ola/PidStoreTest.py; exit \$?" > ./python/ola/PidStoreTest.sh chmod +x ./python/ola/PidStoreTest.sh FAIL: python/ola/PidStoreTest.sh mkdir -p ./python/ola echo "PYTHONPATH=./python PIDSTOREDIR=./data/rdm /usr/bin/python ./python/ola/RDMTest.py; exit \$?" > ./python/ola/RDMTest.sh chmod +x ./python/ola/RDMTest.sh FAIL: python/ola/RDMTest.sh PASS: python/ola/UIDTest.py mkdir -p ./python echo "/usr/bin/python -m compileall data include python scripts tools; exit \$?" > ./python/PyCompileTest.sh chmod +x ./python/PyCompileTest.sh PASS: python/PyCompileTest.sh echo "for FILE in ./tools/ola_trigger/example.conf ./tools/ola_trigger/test_file.conf ./tools/ola_trigger/test_file_falling.conf ./tools/ola_trigger/test_file_rising.conf ./tools/ola_trigger/contrib/mac_volume.conf ./tools/ola_trigger/contrib/mac_itunes.conf ./tools/ola_trigger/contrib/philips_hue_osram_lightify.conf; do echo \"Checking \$FILE\"; ./tools/ola_trigger/ola_trigger --validate \$FILE; STATUS=\$?; if [ \$STATUS -ne 0 ]; then echo \"FAIL: \$FILE caused ola_trigger to exit with status \$STATUS\"; exit \$STATUS; fi; done; exit 0" > ./tools/ola_trigger/FileValidateTest.sh chmod +x ./tools/ola_trigger/FileValidateTest.sh PASS: tools/ola_trigger/FileValidateTest.sh mkdir -p ./python/ola echo "PYTHONPATH=./python /usr/bin/python ./tools/rdm/ResponderTestTest.py; exit \$?" > ./tools/rdm/ResponderTestTest.sh chmod +x ./tools/rdm/ResponderTestTest.sh PASS: tools/rdm/ResponderTestTest.sh PASS: tools/rdm/TestStateTest.py ============================================================================ Testsuite summary for OLA 0.10.8 ============================================================================ # TOTAL: 94 # PASS: 86 # SKIP: 0 # XFAIL: 0 # FAIL: 8 # XPASS: 0 # ERROR: 0 ============================================================================ See ./test-suite.log Please report to open-lighting@googlegroups.com ============================================================================ olad -l 4 in gdb with debug symbols, adding a new universe with the dummy device:olad/plugin_api/PortManager.cpp:119: Patched 1-1-O-0 to universe 0 common/io/EPoller.cpp:306: ss process time was 0.000001 common/io/SelectPoller.cpp:233: ss process time was 0.000009 /usr/include/c++/12.1.0/bits/stl_queue.h:725: std::priority_queue<_Tp, _Sequence, _Compare>::const_reference std::priority_queue<_Tp, _Sequence, _Compare>::top() const [with _Tp = ola::io::TimeoutManager::Event*; _Sequence = std::vector<ola::io::TimeoutManager::Event*>; _Compare = ola::io::TimeoutManager::ltevent; const_reference = ola::io::TimeoutManager::Event* const&]: Assertion '!this->empty()' failed. common/io/EPoller.cpp:306: ss process time was 0.000001 You can find the build script here. Please let me know if you have any hints on what might be missing from the package script to get the tests to pass and this crash to disappear, thanks :) (edit: bt full for better context; terminal formatting) |
|
I did some further debugging and thought the issues are different as @freaknils is getting a segfault while I'm getting an abort, but the same assertion is failing so I'm sure they're related. What solved the crash (and thus 5 out of 8 failing tests) was to disable stdc++ assertions (they're enabled by default by Arch Linux' However I believe enabling assertions should not break a software like this and the root cause should still be fixed. @peternewman does this information help you? The remaining 3 failing tests are python-related (test-suite.log) so I would open a separate issue for that. Update: #1753 fixed the crash and #1757 the failing tests for me. |
|
Glad you fixed your issues too @cbix ! I assume after that you were able to re-enable the assertions again? |
|
@peternewman yes exactly, no more crash with assertions enabled |
HI,
I have just build the current master of OLA, but when I add a new Artnet Universe via the web page the olad crashes:
Distribution is:
CPU:
Are there any known issues or am I doing something wrong?
Thanks!
The text was updated successfully, but these errors were encountered: