[SPARK] mention JobNameSuffixProvider interface #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mellifluous-eclair-326dcd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mobuchowski
reviewed
May 21, 2024
docs/integrations/spark/extending.md
Outdated
| @@ -109,6 +109,10 @@ runtime. | |||
| can also be attached, though `CustomFacetBuilder`s _may_ override facets attached directly to the | |||
| dataset. | |||
|
|
|||
| Spark job's naming logic appends output dataset's identifier as job suffix. In order to provide a job suffix, a `QueryPlanVisitor` | |||
| needs to implement [`JobNameSuffixProvider`](https://github.com/OpenLineage/OpenLineage/blob/main/integration/spark/shared/src/main/java/io/openlineage/spark/api/JobNameSuffixProvider.java) | |||
| interface. Otherwise no suffix will be appended. | |||
There was a problem hiding this comment.
Please explain more what that means - in a concrete example maybe. I think it's important point when implementing own Visitors or Dataset Builders.
There was a problem hiding this comment.
I gave more context to it.
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
pawel-big-lebowski
force-pushed
the
job-suffix
branch
from
41805e5
to
d967df8
Compare
mobuchowski
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.