Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Isuue #20 #32

Merged
merged 3 commits into from Feb 3, 2016

Conversation

@hashhar
Copy link
Contributor

commented Jan 7, 2016

This is a branch looking to fix #20.

I have added a navbar. Yet to add links to proper pages.

Planned to make certain Jekyll subpages (tutorial, release notes) using the markdown files available in the main OLW repo.

@dnfclas

This comment has been minimized.

Copy link

commented Jan 7, 2016

Hi @hashhar, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas dnfclas added the cla-required label Jan 7, 2016

@dnfclas

This comment has been minimized.

Copy link

commented Jan 7, 2016

@hashhar, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@dnfclas dnfclas added cla-signed and removed cla-required labels Jan 7, 2016

@hashhar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2016

This looks like this when rendered.

screenshot 59

@hashhar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2016

Do take notice that the Blog link is dead. It currently points to http://openlivewriter.org/WriterRedirect/WriterBlog which doesn't exist.

@kathweaver

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2016

Didn't you suggest we set up a /_posts/blog

I've put a blog entry there, should that link post to it.

@kathweaver

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2016

We should be able to have multiple authors be able to post there.

@hashhar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2016

I'll check it on my end and see how it works and do changes accordingly.

@kathweaver

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2016

I ran the setup again, and I get the screen mentioned above.

@hashhar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2016

@rebornix I think for the changes I am proposing, #15 has to be merged first. Because in what I have, I am unable to generate any post page when putting files into _posts. I think we have a customized configuration of Jekyll.

@kathweaver

This comment has been minimized.

Copy link
Contributor

commented Jan 20, 2016

I've seeing that also. 👍

@hashhar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2016

@martinwoodward I have added a navbar with:

  • Logo that redirects to site homepage.
  • Link to Homepage
  • Link to News page (See #15 )
  • Link to non-existent blog (IS THIS NEEDED?)

Some other links I think are useful (but haven't added yet):

  • Tutorials and Guides
    • Setup FTP and other support pages as a drop-down
  • Link to star us?
@kathweaver

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2016

Can this be merged please? We've got a bug right now in the documentation and we really can't go further on the website until this is merged -- plus the rest of the pull requests.

@hashhar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2016

In the current state the navigation bar has some broken links,

  • Blog

And some missing links,

  • Tutorials and Guides
  • Star/Fork on GitHub

Other than that, everything works as it should.

@kathweaver

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2016

So should it be merged?

@hashhar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2016

I think so. Nothing is wrong with it.

Merge #15 before merging this.

@RobStand

This comment has been minimized.

Copy link
Member

commented Feb 3, 2016

Merging this. Test it out and submit PRs if anything is wonky.

RobStand added a commit that referenced this pull request Feb 3, 2016

@RobStand RobStand merged commit 2176d7a into OpenLiveWriter:master Feb 3, 2016

@hashhar hashhar deleted the hashhar:navigation branch Feb 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.