Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title music does not stop when unchecked in options window #1763

Closed
AaronVanGeffen opened this issue Jan 23, 2023 · 1 comment · Fixed by #1774
Closed

Title music does not stop when unchecked in options window #1763

AaronVanGeffen opened this issue Jan 23, 2023 · 1 comment · Fixed by #1774
Labels
bug Something isn't working

Comments

@AaronVanGeffen
Copy link
Member

Version information:

  • Platform: Linux
  • Version: 22.12+
  • Build/commit: a26f820

Describe the bug
Title music does not stop when unchecked in options window. The music does start playing when the option is checked (and no music is playing yet), but not the other way around.
@AaronVanGeffen AaronVanGeffen added the bug Something isn't working label Jan 23, 2023
niceeffort referenced this issue Jan 27, 2023
@niceeffort
Fix to stop title music when unchecked
52907a2
@niceeffort
Copy link
Contributor

Pull request #1774 shoudl fix this. Sorry for the confusion with the different branches and commits.

@AaronVanGeffen AaronVanGeffen linked a pull request Jan 28, 2023 that will close this issue
Fix #1763: Title music does not stop when unchecked in options window #1774
Merged
AaronVanGeffen pushed a commit that referenced this issue Jan 29, 2023
@niceeffort
Fix #1763: Title music does not stop when unchecked in options window (…
3f9ce05 
…#1774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1763: Title music does not stop when unchecked in options window niceeffort/OpenLoco
2 participants
@AaronVanGeffen @niceeffort