Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement serialization of keyboard shortcuts #1141

Merged
merged 17 commits into from
Sep 5, 2021

Conversation

AaronVanGeffen
Copy link
Member

@AaronVanGeffen AaronVanGeffen commented Sep 2, 2021

This crude (de)serialization of keyboard shortcuts to the OpenLoco config files, aiming to fix #1135 and allowing for easy extension in the future.

To do:

  • Config saving and loading, using SDL serializer for names
  • Declare defaults for all existing shortcuts and use when missing
  • Check against new shortcut definitions in Keyboard.cpp
  • Update keyboard shortcut window to reflect the new list, while still allowing localisation
  • Shortcuts should be bound to the new declarations, not the old ones
  • Allow rebinding the NumPad Enter key separately (following up on Make keypad enter work the same as normal enter #380)

@AaronVanGeffen AaronVanGeffen changed the title Add crude (de)serialization of keyboard shortcuts Implement serialization of keyboard shortcuts Sep 3, 2021
@AaronVanGeffen AaronVanGeffen marked this pull request as ready for review September 3, 2021 21:18
@AaronVanGeffen AaronVanGeffen added this to the v21.08+ milestone Sep 5, 2021
@AaronVanGeffen AaronVanGeffen merged commit dc9e234 into OpenLoco:master Sep 5, 2021
@AaronVanGeffen AaronVanGeffen deleted the keyboard-shortcuts branch September 5, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts not working
3 participants