Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow the user to view the .dat file name in object selection menu #1696

Merged
merged 6 commits into from
Nov 6, 2022
Merged

allow the user to view the .dat file name in object selection menu #1696

merged 6 commits into from
Nov 6, 2022

Conversation

LeftofZen
Copy link
Contributor

@LeftofZen LeftofZen commented Oct 23, 2022 •
edited

@LeftofZen LeftofZen added the enhancement Changing an existing feature slightly label Oct 23, 2022
@LeftofZen LeftofZen changed the title Allow searching/filtering objects in object selection window allow the user to view the .dat file name in object selection menu Oct 23, 2022
@LeftofZen LeftofZen added the changelog Should get a changelog entry label Oct 23, 2022
@LeftofZen LeftofZen marked this pull request as ready for review October 23, 2022 08:31
@LeftofZen
Copy link
Contributor Author

LeftofZen commented Oct 23, 2022 •
edited

looks like this
image

edit: last 2 lines removed as they're unnecessary at the moment

@AaronVanGeffen
Copy link
Member

looks like this image

The last two lines do not seem to correspond to any code in this PR. Did you remove them?

@LeftofZen
Copy link
Contributor Author

@AaronVanGeffen oh yep I removed them as duncan requested, discussed in #coding on discord

@AaronVanGeffen AaronVanGeffen merged commit dc2ed0a into OpenLoco:master Nov 6, 2022
@duncanspumpkin duncanspumpkin added this to the v22.10+ milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronVanGeffen AaronVanGeffen AaronVanGeffen approved these changes

@duncanspumpkin duncanspumpkin duncanspumpkin approved these changes

Assignees
No one assigned
Labels
changelog Should get a changelog entry enhancement Changing an existing feature slightly
Projects
None yet
Milestone
v22.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeftofZen @AaronVanGeffen @duncanspumpkin