Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Object Load #1842

Merged
merged 5 commits into from Feb 15, 2023
Merged

Conversation

duncanspumpkin
Copy link
Contributor

Getting onto the more annoying load functions. This one had a mistake in the unload! It wasn't clearing the correct values this would mean that packing track objects would mess up! Not sure if that is a known issue.

@duncanspumpkin duncanspumpkin added pending review reverse-engineering For when vanilla functions are reimplemented in C++ labels Feb 13, 2023
Copy link
Member

@AaronVanGeffen AaronVanGeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a changelog entry for the botched unload function (original bug?)

Copy link
Member

@AaronVanGeffen AaronVanGeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading tracks and constructing them appears to be working properly.

@duncanspumpkin duncanspumpkin merged commit 6209690 into OpenLoco:master Feb 15, 2023
@duncanspumpkin duncanspumpkin added this to the v23.01+ milestone Feb 15, 2023
@duncanspumpkin duncanspumpkin deleted the trackObject branch February 15, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reverse-engineering For when vanilla functions are reimplemented in C++
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants