Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road object load #1846

Merged
merged 2 commits into from Feb 15, 2023
Merged

Road object load #1846

merged 2 commits into from Feb 15, 2023

Conversation

duncanspumpkin
Copy link
Contributor

Another object with bad unloads!

@duncanspumpkin duncanspumpkin added pending review reverse-engineering For when vanilla functions are reimplemented in C++ labels Feb 14, 2023
Copy link
Member

@AaronVanGeffen AaronVanGeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading roads and constructing them appears to be working properly.

Also fix unload issues
@duncanspumpkin duncanspumpkin enabled auto-merge (squash) February 15, 2023 20:09
@@ -3,7 +3,7 @@
- Fix: [#1763] Title music does not stop when unchecked in options window.
- Fix: [#1772] Toggling edge scrolling option does not work.
- Fix: [#1798] Memory leak when resizing the window.
- Fix: [#1842] Track and Dock objects incorrectly unloaded causing packing issues.
- Fix: [#1842] Track, Road and Dock objects incorrectly unloaded causing packing issues.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original bug?

Suggested change
- Fix: [#1842] Track, Road and Dock objects incorrectly unloaded causing packing issues.
- Fix: [#1842] Track, Road and Dock objects incorrectly unloaded causing packing issues. (Original bug)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh true. I'll get it with vehicles I'm sure they have a bug.

@duncanspumpkin duncanspumpkin merged commit 6fd8955 into OpenLoco:master Feb 15, 2023
@duncanspumpkin duncanspumpkin deleted the roadObject branch February 15, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reverse-engineering For when vanilla functions are reimplemented in C++
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants