Early work on macOS builds #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes compilation only, doesn't let it link just yet
Closed
This creates appropriate sections, but only uses default linker script for now.
Based on binutils 2.29.1-2
This marks text section as rwx, so we can patch our custom hooks
janisozaur
reviewed
Jan 20, 2018
| // result = fs::path(path) / "OpenLoco"; | ||
| // } | ||
| // CoTaskMemFree(path); | ||
| return "~"; |
There was a problem hiding this comment.
This won't fly. ~ is a shell shorthand, it's not available through C++.
janisozaur
pushed a commit
to janisozaur/OpenLoco
that referenced
this pull request
Jan 20, 2018
Extracted from OpenLoco#5
janisozaur
pushed a commit
to janisozaur/OpenLoco
that referenced
this pull request
Jan 20, 2018
Extracted from OpenLoco#5
This was referenced Jan 20, 2018
Merged
janisozaur
pushed a commit
to janisozaur/OpenLoco
that referenced
this pull request
Jan 20, 2018
Extracted from OpenLoco#5
|
As far as I'm concerned, all the changes (relating to Linux builds) were covered in #10. @marijnvdwerf can you confirm other changes were also ported to #14 and close this issue? |
|
As far as I'm aware: yes |
marijnvdwerf
added a commit
to marijnvdwerf/OpenLoco
that referenced
this pull request
Feb 21, 2019
Decompile select vehicle window functions
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.