Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reasonable defaults throughout Aviary #291

Open
johnjasa opened this issue May 29, 2024 · 1 comment
Open

Make reasonable defaults throughout Aviary #291

johnjasa opened this issue May 29, 2024 · 1 comment
Labels
enhancement New feature or request epic Long-term work that can't be resolved with single pull request

Comments

@johnjasa
Copy link
Member

Desired capability or behavior.

Make reasonable defaults for Aviary throughout the code, especially if the options are subtly different. Whichever converges more reliably should be the default, after that then the one with the fewest number of inputs makes sense, or something where you can measure the physical properties of the aircraft. Do this throughout the code and for most all levels.

This issue is broad on purpose; please consider this for all parts of code you're developing

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response

@jkirk5 jkirk5 added enhancement New feature or request epic Long-term work that can't be resolved with single pull request labels Jun 26, 2024
@jkirk5
Copy link
Contributor

jkirk5 commented Jun 26, 2024

This is a good opportunity to break from legacy code defaults. When converting a file from FLOPS or GASP, we can use the legacy code's defaults whenever there is a difference between Aviary defaults and the legacy code defaults. Basically add those variables to the .csv so they overwrite the Aviary defaults.

For Aviary, a decision must be made on what the purpose of defaults is - is it to provide "reasonable" values so they are not required? If so, what aircraft type/class should these defaults target? Should "required" inputs still have a default, or should they default to 0 or None to force users to select a value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic Long-term work that can't be resolved with single pull request
Projects
None yet
Development

No branches or pull requests

2 participants