Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify teams #103

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Notify teams #103

merged 6 commits into from
Jan 25, 2024

Conversation

crecine
Copy link
Contributor

@crecine crecine commented Jan 24, 2024 •
edited

Summary

This creates a workflow that will send notifications to the Aviary pull request channel.
If reviewers are assigned when the pull request is created, the first two will be tagged in the tasks.
Currently, reviewers added after the PR is opened will not be tagged.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@crecine crecine requested a review from johnjasa January 25, 2024 00:31
robfalck
robfalck approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@robfalck robfalck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I hadn't tried to do anything like this in the other repos yet. I don't see any problems with the secrets, and I'm interested to see how well this works.

@crecine
Copy link
Contributor Author

crecine commented Jan 25, 2024

Interesting, I hadn't tried to do anything like this in the other repos yet. I don't see any problems with the secrets, and I'm interested to see how well this works.

I got the issue with the secrets worked out. The issue was using pull_request vs pull_request_target, the first runs in the repo the changes are coming from, the latter runs in the repo the changes are being merged into.
I can walk you through the Teams side, if you'd like.

@johnjasa johnjasa added this pull request to the merge queue Jan 25, 2024
@crecine crecine removed this pull request from the merge queue due to a manual request Jan 25, 2024
@crecine crecine added this pull request to the merge queue Jan 25, 2024
Merged via the queue into OpenMDAO:main with commit ff2a547 Jan 25, 2024
7 checks passed
@crecine crecine deleted the notify_teams branch February 7, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robfalck robfalck robfalck approved these changes

@johnjasa johnjasa johnjasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crecine @robfalck @johnjasa