-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 11 Resolution - ALTITUDE_RATE_MAX add to GASP ODEs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cannot find THRUST_MAX_TOTAL
…fic folder, upd flightpath.ode with ALTITUDE_RATE_MAX
ehariton
changed the title
Issue 11 - ALTITUDE_RATE_MAX add to GASP ODEs
Issue 11 Resolution - ALTITUDE_RATE_MAX add to GASP ODEs
Jan 18, 2024
crecine
reviewed
Jan 22, 2024
Co-authored-by: crecine <51181861+crecine@users.noreply.github.com>
johnjasa
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig this! I'm going to continue this work once #88 is in. That'll make it easier to expose this in a cohesive way.
crecine
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding
ALTITUDE_RATE_MAX
as output from GASP ODEsStatus - simple implementation just on Climb_ODE failing tests because of no access to
THRUST_MAX_TOTAL
Related Issues
Works towards #11 but we need #88 in first.
Backwards incompatibilities
None
New Dependencies
None