Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to height energy mission based on Ken's feedback #94

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Improvements to height energy mission based on Ken's feedback #94

merged 5 commits into from
Jan 25, 2024

Conversation

johnjasa
Copy link
Member

Summary

This is a minor PR to resolve some capability needed for MBSA&E work.

Backwards incompatibilities

None

New Dependencies

None

@Kenneth-T-Moore
Copy link
Member

Thanks, John. I removed my workarounds, and these fixes work.

Kenneth-T-Moore
Kenneth-T-Moore requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Kenneth-T-Moore Kenneth-T-Moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small problem with the takeoff-cruise altitude connection.

@johnjasa
Copy link
Member Author

Found a small problem with the takeoff-cruise altitude connection.

Fixed and pushed up to here! Thanks Ken.

Kenneth-T-Moore
Kenneth-T-Moore approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@Kenneth-T-Moore Kenneth-T-Moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got the n3cc working reasonably well right now. There are a couple of issues, but they are unrelated to this PR, so I think it is ready.

@crecine crecine added this pull request to the merge queue Jan 25, 2024
@johnjasa johnjasa mentioned this pull request Jan 25, 2024
Merged
Merged via the queue into OpenMDAO:main with commit b1505df Jan 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kenneth-T-Moore Kenneth-T-Moore Kenneth-T-Moore approved these changes

@crecine crecine crecine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@johnjasa @Kenneth-T-Moore @crecine