Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Radau, BDF and LSODA as options for scipy's integration method when using simulate #675

Merged
merged 15 commits into from
Nov 18, 2021

Conversation

joel-martin
Copy link
Contributor

Summary

  • Added Radau, BDF and LSODA to option method of dymos.phase.options.SimulateOptionsDictionary .
  • Added example for a stiff ODE system.
  • Added test for the example.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

docs/_toc.yml Outdated Show resolved Hide resolved
@joel-martin
Copy link
Contributor Author

https://github.com/joel-martin/dymos/blob/017c5529e85d9cad1ad29baeaffae69aba6b36cb/dymos/examples/robertson_problem/doc/test_doc_robertson_problem.py#L97

This line of code still fails. The relative error rel error 0.00835626525078177 is high, but perhaps acceptable because it is the result at the end of the time integration. The next test could also be a problem.

https://github.com/joel-martin/dymos/blob/017c5529e85d9cad1ad29baeaffae69aba6b36cb/dymos/examples/robertson_problem/doc/test_doc_robertson_problem.py#L98

Should I reduce the tolerances further?

@robfalck
Copy link
Contributor

I'm ok with lowering that tolerance because it's still a small relative error on a very small absolute error, and at this point we're basically testing the accuracy of the integrator in scipy, not the functionality of dymos

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 95.369% when pulling 4e2c0c2 on joel-martin:implicit-simulate into 02e4f36 on OpenMDAO:master.

@robfalck robfalck changed the title Implicit simulate Added Radau, BDF and LSODA as options for scipy's integration method when using simulate Nov 18, 2021
@robfalck robfalck merged commit f65d7ff into OpenMDAO:master Nov 18, 2021
@robfalck
Copy link
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable implicit methods of solve_ivp in traj.simulate
3 participants