openmpt123: fix build on gcc-12 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gcc-12` cleaned up implicit header includes and now requires
explicit '<memory>' for 'std::unique_ptr<>':
openmpt123/openmpt123.cpp:194:14: error: 'unique_ptr' in namespace 'std' does not name a template type
194 | std::unique_ptr<file_audio_stream_base> impl;
| ^~~~~~~~~~
openmpt123/openmpt123.cpp:109:1: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
108 | #include "openmpt123_waveout.hpp"
+++ |+#include <memory>
109 |
|
Thanks for the report. Applied in upstream SVN repository as https://source.openmpt.org/browse/openmpt/?op=revision&rev=15911 and backported to 0.5 as https://source.openmpt.org/browse/openmpt/?op=revision&rev=15912. |
manxorist
added a commit
that referenced
this pull request
Nov 13, 2021
…required by standard and exposed by GCC 12. Fixes <#8>. Patch-by: Sergei Trofimovich <slyich@gmail.com> git-svn-id: https://source.openmpt.org/svn/openmpt/trunk/OpenMPT@15911 56274372-70c3-4bfc-bfc3-4c3a0b034d27
manxorist
added a commit
that referenced
this pull request
Nov 13, 2021
[Fix] openmpt123: Add missing header <memory> for std::unique_ptr as required by standard and exposed by GCC 12. Fixes <#8>. Patch-by: Sergei Trofimovich <slyich@gmail.com> ........ git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.29@15912 56274372-70c3-4bfc-bfc3-4c3a0b034d27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc-12cleaned up implicit header includes and now requiresexplicit '' for 'std::unique_ptr<>':