[FIX] pyOpenMS Qt5 for macOS #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to check which includes are passed from openms (it's external includes which include qt5core and qt5network at least). Probably the QT5 root dir is missing (which needs to be there because we prefix the includes with the subdirectory). Maybe we pass this directory by other means somehow on the build machines. I will take a close look on Monday. |
|
Thanks for the suggestion, the new patch enables building pyOpenMS on macOS again. |
|
No problem. The changes make sense. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QT_LIBRARY_DIRunfortunately doesn't exist with Qt5 anymore and pyOpenMS can't be built under macOS. This patch ensures that the libraries can be copied. Unfortunately, the problem #3301 persists.clang can't find the Qt5 headers. Did anybody observe similar issues?