[REFACTOR] function to copy spectrum meta data / settings #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbielow
reviewed
Jan 9, 2019
| output.setRT(input.getRT()); | ||
| output.setMSLevel(input.getMSLevel()); | ||
| output.setName(input.getName()); | ||
| output.setType(SpectrumSettings::CENTROID); |
There was a problem hiding this comment.
output.setType(SpectrumSettings::CENTROID);
output.getFloatDataArrays().clear();
are effectively removed now. But it seems like they are needed.
src/openms/source/ANALYSIS/XLMS/OPXLSpectrumProcessingAlgorithms.cpp
Outdated
Show resolved
Hide resolved
| output[scan_idx].setRT(input[scan_idx].getRT()); | ||
| output[scan_idx].setMSLevel(input[scan_idx].getMSLevel()); | ||
| output[scan_idx].setName(input[scan_idx].getName()); | ||
| output[scan_idx].setType(SpectrumSettings::CENTROID); |
There was a problem hiding this comment.
hmm I see, this is not just copying over the settings but over-writing it.
hroest
commented
Jan 9, 2019
src/openms/include/OpenMS/TRANSFORMATIONS/RAW2PEAK/PeakPickerIterative.h
Show resolved
Hide resolved
hroest
commented
Jan 9, 2019
hroest
commented
Jan 9, 2019
hroest
commented
Jan 9, 2019
|
otherwise +1 |
|
what about the |
cbielow
reviewed
Jan 24, 2019
MSSpectrum does not inherit directly from MetaInfoInterface, so that should be covered by SpectrumSettings: OpenMS/src/openms/include/OpenMS/KERNEL/MSSpectrum.h Lines 67 to 70 in 1c5cf83 |
timosachsenberg
changed the title
timosachsenberg
approved these changes
Dec 27, 2021
|
tests passed according to cdash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract single function to copy spectral settings (but not data) from one spectrum to another