Faster write of (id)XML #3976
Merged
Faster write of (id)XML #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rWrites # Conflicts: # contrib
|
looks good to me |
hroest
reviewed
Feb 21, 2019
| if (it2 != proteinid_to_accession_.end()) | ||
| { | ||
| PeptideEvidence pe; | ||
| pe.setProteinAccession(it2->second); | ||
| peptide_evidences_.push_back(pe); | ||
| peptide_evidences_.push_back(std::move(pe)); |
There was a problem hiding this comment.
is PeptideEvidence moveable?
There was a problem hiding this comment.
yes it is. If it were not, this would just make it an r-value and copy assignment would kick in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even faster writing of idXML (mostly) by avoiding needless copies and using number->string conversion of OpenMS instead of std::ostream.
Also:
[FIX] Fix a bug in ClassTest.h's
TEST_FILE_EQUAL(....)which would report the line of the previous TEST_ macro as point of failure, see https://github.com/OpenMS/OpenMS/compare/develop...cbielow:fasterWrites?expand=1#diff-b194e44883fffa6c069caae5d0164329R709