-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation of output prefix parameters #4527
Merged
timosachsenberg
merged 12 commits into
OpenMS:develop
from
bernt-matthias:topic/output_prefix
Jan 7, 2022
Merged
implementation of output prefix parameters #4527
timosachsenberg
merged 12 commits into
OpenMS:develop
from
bernt-matthias:topic/output_prefix
Jan 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as discussed in OpenMS#4404 implementation for SeedListGenerator currently only works for consensusXML input. For this tool one could think about to have the -out and the -out_prefix that could be used exclusively. for the -out_prefix parameter a question would be how the names should be generated for the other input types.
29 tasks
This looks like a great start. Indeed the CTD changes are missing, but at least the prefix type already exists there. I will try to add to this PR when I find time again. |
any update here? |
/rebase |
timosachsenberg
force-pushed
the
topic/output_prefix
branch
from
January 5, 2022 18:35
bdb3a87
to
b3154a6
Compare
jpfeuffer
reviewed
Jan 5, 2022
jpfeuffer
reviewed
Jan 5, 2022
jpfeuffer
reviewed
Jan 5, 2022
Co-authored-by: Julianus Pfeuffer <pfeuffer@informatik.uni-tuebingen.de>
timosachsenberg
approved these changes
Jan 7, 2022
Tests pass and ini ctd contain the entry:
CTD
|
timosachsenberg
changed the title
initial implementation of output prefix parameters
implementation of output prefix parameters
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #4404
implementation for SeedListGenerator currently only works for consensusXML input. For this tool one could think about to have the -out and the -out_prefix that could be used exclusively. for the -out_prefix parameter a question would be how the names should be generated for the other input types.
TODOs: