[Feature] FFC/FeatureFinderAlgorithmPicked speedup #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed scores-vector. Working on the trace_score (double) should be sufficient here. Stored map[s +- i] in next_spectrum to prevent multiple accesses. Was probably already optimized by the compiler. Not tested!
Changed all for-Loops to ranged based for-Loops where CLion recommended it Removed checks for OMP: #pragma omp parallel does nothing without OMP Changed a few occurences of push_back to emplace_back where possible
Small changes similar to the commits before
Instead of changing feature_ok to false and returning it at the end, just instant return false. Prevents multiple if(feature_ok) branches.
There werde multiple occurences of commented continue()-s. Now there are uncommented and the following else parts aren't necessary anymore and were removed
IceFreez3r
changed the title
|
someone else wants to have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked once more at FeatureFinderCentroided.
As the main runtime goes into
run(), I focused on that. For exact changes look into the single commits. I think they explain quiet good, what happened.As a result the runtime reduced from
1:21:54to1:07:29(Wall)I compared the output file from the "develop"-Branch and from my "ffc-testzone"-Featurebranch with FuzzyFinder. For some reason the representation of the intensities changed in the output. This lead to some decimal points being cut off and to a slightly changed output:
I also ran all the tests and they all passed.
If someone is interested in working on this in the future again: I refactored the individual steps in run(), so that they appear in perf and one can see where the runtime disappears.
