Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Arrangement Changes #7 #5471

Merged
merged 2 commits into from Aug 3, 2021
Merged

Conversation

Arraxx
Copy link
Contributor

@Arraxx Arraxx commented Jul 31, 2021

Description

code arrangement changes for better readability.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

#include <map>
#include <set>
#include <list>
#include<bits/stdc++.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably doesn't exist

double mz2 = 0.0;
if (!y.getPrecursors().empty())
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you do this manually? Because I think a proper way would be to do clang format once

Copy link
Contributor

@timosachsenberg timosachsenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks

@timosachsenberg timosachsenberg merged commit b47dbde into OpenMS:develop Aug 3, 2021
timosachsenberg added a commit that referenced this pull request Aug 12, 2021
* Code Arrangement Changes #7 (#5471)

* Code Arrangement Changes #7

* Update ClusterAnalyzer.cpp

Co-authored-by: Arraxx <kumaramanjha2901@gmail.com>

* Added wrap-doc methods #10 (#5467)

* Added wrap-doc methods #10

* Added wrap-doc methods #7 (#5445)

* Wrap-doc methods added #7

* Added wrap-doc methods #11 (#5468)

* Added wrap-doc methods #11

* Added wrap-doc methods #9 (#5465)

* Added wrap-doc methods #9

* minor fixes (#5474)

* Adding Wrap Doc Method (#5389)

* add wrap doc #1

* Added wrap-doc methods #8 (#5459)

* Added wrap-doc methods #8

* Code Arrangement Changes #8 (#5476)

Co-authored-by: Arraxx <kumaramanjha2901@gmail.com>

* fix bug in featureXML schema

* fix bug in 1.8 schema

Co-authored-by: Samuel Wein <sam@samwein.com>
Co-authored-by: Aman Kumar <54955755+Arraxx@users.noreply.github.com>
Co-authored-by: Arraxx <kumaramanjha2901@gmail.com>
Co-authored-by: Rahul Agrawal <41531498+rahul799@users.noreply.github.com>
Co-authored-by: Oliver Alka <randalthor89@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants