Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug if experimental design is not given #5522

Merged
merged 1 commit into from Sep 7, 2021

Conversation

timosachsenberg
Copy link
Contributor

@timosachsenberg timosachsenberg commented Sep 7, 2021

now treated as unfractionated

Description

We previously decided to fall back to unfractionated but the initial implementation had a bug.
Should be fixed now with this PR

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

now treated as unfractionated
@timosachsenberg timosachsenberg changed the title fix bug if experimental design is given fix bug if experimental design is not given Sep 7, 2021
@timosachsenberg
Copy link
Contributor Author

failed test unrelated

@timosachsenberg timosachsenberg merged commit 0593c32 into develop Sep 7, 2021
@timosachsenberg timosachsenberg deleted the fix/plfq_no_exp_design branch September 7, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants