Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a-B fragment masses for DNA #5587

Merged
merged 6 commits into from
Dec 11, 2021

Conversation

poshul
Copy link
Collaborator

@poshul poshul commented Oct 14, 2021

Description

Fixes an existing issue where custom deoxyribose mods (with the naming convention [d*]) were not producing the correct masses for base loses.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@poshul poshul marked this pull request as draft October 14, 2021 14:10
@hroest
Copy link
Contributor

hroest commented Oct 18, 2021

could you add a regression test?

@poshul
Copy link
Collaborator Author

poshul commented Dec 9, 2021

could you add a regression test?

Done, also added test for base methylation.

@poshul poshul marked this pull request as ready for review December 9, 2021 15:38
Copy link
Contributor

@timosachsenberg timosachsenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct to me

@timosachsenberg timosachsenberg merged commit 0810ebf into OpenMS:develop Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants