Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move GNPSExport to lib #5638

Merged
merged 10 commits into from
Jan 13, 2022
Merged

move GNPSExport to lib #5638

merged 10 commits into from
Jan 13, 2022

Conversation

timosachsenberg
Copy link
Contributor

@timosachsenberg timosachsenberg commented Nov 5, 2021

Description

Moves GNPSExport functionality to library. Some smaller fixes.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg
Copy link
Contributor Author

rebuild jenkins

1 similar comment
@timosachsenberg
Copy link
Contributor Author

rebuild jenkins

@hroest
Copy link
Contributor

hroest commented Nov 8, 2021

can you add a unit test for this class?

@jpfeuffer
Copy link
Contributor

Error compiling Cython file:
------------------------------------------------------------
...
        #  DefaultParamHandler        

        GNPSMGFFile() nogil except +
        GNPSMGFFile(GNPSMGFFile &) nogil except +

        void run(String & consensus_file_path, StringList & mzml_file_paths, String & out) nogil except + # wrap-doc:Export consensus file from default workflow to GNPS MGF format
                                              ^
------------------------------------------------------------

@timosachsenberg
Copy link
Contributor Author

rebuild jenkins

@timosachsenberg timosachsenberg merged commit b8f8567 into develop Jan 13, 2022
@timosachsenberg timosachsenberg deleted the feature/GNPS_to_lib branch January 13, 2022 10:53
@timosachsenberg
Copy link
Contributor Author

tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants